-
Notifications
You must be signed in to change notification settings - Fork 175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix for multi-seg-in-flight #1782
Conversation
@jailuthra can you take a look? I think in case of call to |
4201123
to
6d7cd2b
Compare
'SegsInFlight' is lost in case of session refresh
of session refresh
6d7cd2b
to
1b59591
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the delayed response.
Good catch & LGTM!
EDIT: Before merge it would be amazing if we can update the pending Changelog file for v0.5.16 eaf986b
@jailuthra sorry I saw your comment about Changelog right after I've pressed 'merge' button |
What does this pull request do? Explain your changes. (required)
Fixes case where data in
SegsInFlight
array gets lost after session refreshSpecific updates (required)
lastSess
field.How did you test each of these updates (required)
Unit test.
Does this pull request close any open issues?
Checklist:
./test.sh
pass