Linux build and test GH action #1791
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yondonfu
requested review from
darkdarkdragon,
iameli,
jailuthra and
kyriediculous
iameli
approved these changes
Mar 12, 2021
|
Ignoring the CircleCI error and merging since we're removing that integration anyway. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this pull request do? Explain your changes. (required)
Replace CircleCI with a GH action for the Linux build and test. GH actions seem to help a bit with our flaky tests. The main differences in the default hardware specs for a GH action machine vs. a CircleCI machine seem to be 2 vCPUs vs. 2 core CPU and 7GB RAM vs. 4GB RAM.
I also spotted a test in 6a707bd that was failing consistently in the GH action so I added a sleep since the test checks for async behavior which seems to help.
The CircleCI build will always fail now because I've removed the CircleCI config file. The integration can be removed in CircleCI if/when this PR is merged.
References:
Specific updates (required)
See commit history.
How did you test each of these updates (required)
Ran CI.
Does this pull request close any open issues?
Fixes #1771 ...for now I think.
Checklist:
./test.shpass