Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI: fix max gas price when not specified #1810

Merged
merged 2 commits into from
Apr 7, 2021
Merged

CLI: fix max gas price when not specified #1810

merged 2 commits into from
Apr 7, 2021

Conversation

kyriediculous
Copy link
Contributor

@kyriediculous kyriediculous commented Mar 23, 2021

What does this pull request do? Explain your changes. (required)
Fixes displaying max gas price in the CLI when it's not specified. Now shows "n/a".

How did you test each of these updates (required)
Tested on rinkeby

image

image

Does this pull request close any open issues?
Fixes #1807

Checklist:

@kyriediculous kyriediculous requested a review from yondonfu March 23, 2021 17:58
@kyriediculous kyriediculous marked this pull request as ready for review March 23, 2021 17:58
Copy link
Member

@yondonfu yondonfu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a minor pending changelog comment and then good to go.

CHANGELOG_PENDING.md Outdated Show resolved Hide resolved
Copy link
Member

@yondonfu yondonfu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kyriediculous kyriediculous merged commit b29cb70 into master Apr 7, 2021
@kyriediculous kyriediculous deleted the nv/maxgas branch April 7, 2021 01:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

livepeer_cli: 0.0000<nil> GWei for max gas price
2 participants