Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd,eth: remove deprecated flags #1838

Merged
merged 3 commits into from
Apr 13, 2021
Merged

cmd,eth: remove deprecated flags #1838

merged 3 commits into from
Apr 13, 2021

Conversation

kyriediculous
Copy link
Contributor

@kyriediculous kyriediculous commented Apr 12, 2021

What does this pull request do? Explain your changes. (required)
Remove deprecated flags

Specific updates (required)

  • Remove storage object flags (gs, s3)
  • Remove gasPrice flag
  • Remove superfluous GetGasInfo code

How did you test each of these updates (required)
Ran unit tests

Does this pull request close any open issues?
Fixes #1798

Checklist:

Copy link
Member

@yondonfu yondonfu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like one of the tests in test_args.sh failed likely due to a reason described in one of my review comments.

CHANGELOG_PENDING.md Outdated Show resolved Hide resolved
test_args.sh Outdated Show resolved Hide resolved
test_args.sh Outdated Show resolved Hide resolved
cmd/livepeer/livepeer.go Outdated Show resolved Hide resolved
Copy link
Member

@yondonfu yondonfu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after squashing

@kyriediculous kyriediculous merged commit fe6a6de into master Apr 13, 2021
@kyriediculous kyriediculous deleted the nv/remove-flags branch April 13, 2021 02:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove deprecated flags for 0.5.17
2 participants