Allow to pass region in the custom s3 storage url #1854
Conversation
There was a problem hiding this comment.
Is the part of the path before the bucket name always the region name for S3 compatible APIs or is this a filebase.com specific convention? And related to that: is it possible for a path to have multiple parts before the bucket name such that none of the parts should be treated as a region name i.e. not-a-region/also-not-a-region/bucket-name?
Also, please make sure to update the pending changelog according to the contribution guide.
|
|
||
| func TestCustomS3URLWithRegion(t *testing.T) { | ||
| assert := assert.New(t) | ||
| os, err := ParseOSURL("s3+http://user:password@example.com:9000/path/to/region-name/bucket-name", true) |
There was a problem hiding this comment.
What happened to /path/to? There's no assert.Equal that has it.
There was a problem hiding this comment.
It is ignored. It was always ignored (hosturl.Path = "")
Was it working before? We're just throwing out |
|
Hmm, it was my intent to have that work when I wrote the spec and implementation. If that's not happening, I think that's a bug. Sometimes stuff is in subdirectories. |
Actually I've looked into minio's docs - it can't be ran on subpath (minio/minio#5947 (comment)) |
|
Oh, hah. Okay. I'm cool with this, then. |
There is no convention for such URLs. |
darkdarkdragon
force-pushed
the
it/custom-s3-region
branch
from
f860a6f to
5153377
Compare
|
@yondonfu added changelog |
CHANGELOG_PENDING.md
Outdated
| @@ -7,6 +7,7 @@ | |||
| #### General | |||
|
|
|||
| - \#1848 Use fee cut instead of fee share for user facing language in the CLI (@kyriediculous) | |||
| - \#1854 Allow to pass region in the custom s3 storage URL (@kdarkdarkdragon) | |||
There was a problem hiding this comment.
Looks like there is an extra k in the username
s3+http://user:password@example.com:9000/path/to/region-name/bucket-name
darkdarkdragon
force-pushed
the
it/custom-s3-region
branch
from
5153377 to
1559bf4
Compare
What does this pull request do? Explain your changes. (required)
All the previous S3-compatible storages we've tested was ignoring 'region' part of configuration.
So in our code it was hardcoded as value 'ignored'.
But filebase.com does want it to be set to specific value.
This updates allows to pass region as the part of the custom URL, like this:
s3+http://user:password@example.com:9000/path/to/region-name/bucket-nameSpecific updates (required)
Change parsing of custom s3 url
How did you test each of these updates (required)
unit test
Does this pull request close any open issues?
Checklist:
makeruns successfully./test.shpass