Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

eth: discard gas prices below minGasPrice #1860

Merged
merged 1 commit into from
Apr 29, 2021
Merged

eth: discard gas prices below minGasPrice #1860

merged 1 commit into from
Apr 29, 2021

Conversation

kyriediculous
Copy link
Contributor

@kyriediculous kyriediculous commented Apr 29, 2021

What does this pull request do? Explain your changes. (required)
Adds a minGasPrice to the gas price monitor and discards fetched gas prices below it

Sets a specific setting for mainnet

How did you test each of these updates (required)
Unit tests

Does this pull request close any open issues?
Fixes #1851

Checklist:

@kyriediculous kyriediculous requested a review from yondonfu April 29, 2021 16:18
Copy link
Member

@yondonfu yondonfu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM. Just a few minor comments. After those are addressed and a changelog entry is added should be good to go.

cmd/livepeer/livepeer.go Outdated Show resolved Hide resolved
eth/gaspricemonitor.go Show resolved Hide resolved
eth/gaspricemonitor_test.go Show resolved Hide resolved
@yondonfu
Copy link
Member

Good to go after a changelog entry.

@kyriediculous
Copy link
Contributor Author

added changelog entry and rebased

Copy link
Member

@yondonfu yondonfu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Many insufficient faceValue ticket face value for redeem tx cost errors
2 participants