OAuth2 support #43
Merged
OAuth2 support #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey there, with the recently pushed commits I finished up the remaining todos. Thus I'd kindly ask you two review the code and merge if you thinks it's good or give me some feedback :) Thank you very much :) |
|
I think this looks great. I'd like to merge and cut a release soon. What do you say @timbogit? |
|
|
... and sorry for the delay in reviewing this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adresses #42
This is a proposal based on the 2. option mentioned in the issue. I wanted to open the PR early to get early feedback. However, there are a few todos left.
Todo: