test for compact passes

ljharb · Sep 9, 2010 · ec171ba · ec171ba
1 parent 0d8e1e6
commit ec171ba
Show file tree

Hide file tree

Showing 3 changed files with 21 additions and 2 deletions.
diff --git a/lib/hash.js b/lib/hash.js
@@ -86,7 +86,7 @@ function Hash (hash, extra) {
     } });
 
     Object.defineProperty(self, 'compact', { get : function () {
-        return Hash(hash).filter(function (x) { return x !== undefined });
+        return self.filter(function (x) { return x !== undefined });
     } });
 
     Object.defineProperty(self, 'clone', { get : function () {

diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
     "name" : "traverse",
-    "version" : "0.1.3",
+    "version" : "0.1.4",
     "description" : "Traverse and transform objects by visiting every node on a recursive walk.",
     "author" : "James Halliday",
     "license" : "MIT/X11",

diff --git a/test/hash.js b/test/hash.js
@@ -95,3 +95,22 @@ exports.extract = function (assert) {
     assert.equal(hash.valuesAt(['a','b']).join(' '), '1 2');
 };
 
+exports.compact = function (assert) {
+    var hash = {
+        a : 1,
+        b : undefined,
+        c : false,
+        d : 4,
+        e : [ undefined, 4 ],
+        f : null
+    };
+    var ins = sys.inspect(hash);
+    var compacted = Hash(hash).compact;
+    assert.equal(sys.inspect(hash), ins, 'compact modified the hash');
+    assert.equal(compacted.keys.sort().join(' '), 'a c d e f');
+    assert.equal(compacted.items.a, hash.a);
+    assert.equal(compacted.items.c, hash.c);
+    assert.equal(compacted.items.d, hash.d);
+    assert.equal(compacted.items.e.join(' '), hash.e.join(' '));
+    assert.equal(compacted.items.f, hash.f);
+};