missing comma fixed the regexp test and also an implementation for ty…

…peof "function"
ljharb · Jun 3, 2011 · fc23e4f · fc23e4f
1 parent b9d1110
commit fc23e4f
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 7 deletions.
diff --git a/index.js b/index.js
@@ -81,7 +81,13 @@ Traverse.prototype.deepEqual = function (obj) {
         else if (x === y) {
             // nop
         }
-        else if (typeof y === 'object') {
+        else if (typeof x === 'function') {
+            if (x instanceof RegExp) {
+                // both regexps on account of the __proto__ check
+                if (x.toString() != y.toString()) notEqual();
+            }
+        }
+        else if (typeof x === 'object') {
             if (x === null || y === null) {
                 if (x !== y) notEqual();
             }
@@ -91,8 +97,9 @@ Traverse.prototype.deepEqual = function (obj) {
                     notEqual();
                 }
             }
-            else if (x instanceof Date && y instanceof Date) {
-                if (x.getTime() !== y.getTime()) {
+            else if (x instanceof Date || y instanceof Date) {
+                if (!(x instanceof Date) || !(y instanceof Date)
+                || x.getTime() !== y.getTime()) {
                     notEqual();
                 }
             }

diff --git a/test/equal.js b/test/equal.js
@@ -48,14 +48,12 @@ exports.deepInstances = function () {
     ));
 
     assert.ok(traverse.deepEqual(
-        [ new RegExp('x') ]
-        [ /x/ ],
+        [ new RegExp('x') ], [ /x/ ],
         'regexp instances are real regexps'
     ));
 
     assert.ok(!traverse.deepEqual(
-        [ new RegExp(/./) ]
-        [ /../ ],
+        [ new RegExp(/./) ], [ /../ ],
         'these regexps aren\'t the same'
     ));