Avoid Array#splice

#268 (comment)
ljharb · Jul 27, 2018 · 4e65517 · 4e65517
1 parent 228956b
commit 4e65517
Showing 1 changed file with 5 additions and 1 deletion.
diff --git a/lib/parse.js b/lib/parse.js
@@ -42,6 +42,7 @@ var parseValues = function parseQueryStringValues(str, options) {
     var limit = options.parameterLimit === Infinity ? undefined : options.parameterLimit;
     var parts = cleanStr.split(options.delimiter, limit);
     var charset = options.charset;
+    var skipIndex = -1; // Keep track of where the utf8 sentinel was found
     var i;
 
     if (options.utf8Sentinel) {
@@ -52,13 +53,16 @@ var parseValues = function parseQueryStringValues(str, options) {
                 } else if (parts[i] === isoSentinel) {
                     charset = 'iso-8859-1';
                 }
-                parts.splice(i, 1);
+                skipIndex = i;
                 i = parts.length; // The eslint settings do not allow break;
             }
         }
     }
 
     for (i = 0; i < parts.length; ++i) {
+        if (i === skipIndex) {
+            continue;
+        }
         var part = parts[i];
 
         var bracketEqualsPos = part.indexOf(']=');