Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Perf boost #77

Closed
AdriVanHoudt opened this issue Mar 19, 2015 · 4 comments
Closed

Perf boost #77

AdriVanHoudt opened this issue Mar 19, 2015 · 4 comments
Assignees
Labels
Milestone

Comments

@AdriVanHoudt
Copy link

io.js 1.6.0 landed a perf boost for parse and stringify maybe worth taking a look at? nodejs/node#847

@nlf nlf added the question label Mar 20, 2015
@nlf nlf added this to the 3.0.0 milestone May 21, 2015
@nlf nlf self-assigned this May 21, 2015
@nlf
Copy link
Collaborator

nlf commented May 22, 2015

the encode method for stringifying had a substantial impact, nothing else really applies to our code base. still, was worth looking, thanks!

@AdriVanHoudt
Copy link
Author

So did you change anything? Else this issue can be closed.

On Fri, 22 May 2015 21:03 Nathan LaFreniere notifications@github.com
wrote:

the encode method for stringifying had a substantial impact, nothing else
really applies to our code base. still, was worth looking, thanks!


Reply to this email directly or view it on GitHub
#77 (comment).

@nlf
Copy link
Collaborator

nlf commented May 22, 2015

I did, I incorporated the encode method. Working on writing some additional tests.

@AdriVanHoudt
Copy link
Author

OK cool, glad I could help, certainly for something that is used a lot even
a small perf gain can do a lot in the long run

On Fri, 22 May 2015 21:08 Nathan LaFreniere notifications@github.com
wrote:

I did, I incorporated the encode method. Working on writing some
additional tests.


Reply to this email directly or view it on GitHub
#77 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants