Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

After upgrade to through@2.3.10, build failure with error Cannot find moudle 'call-bind' #1

Closed
charlesh21 opened this issue Oct 11, 2023 · 6 comments · Fixed by #2
Closed

Comments

@charlesh21
Copy link

Hi ljhard,

When my project upgrade to 2.3.10, the build failure with the error Cannot find moudle 'call-bind'

Do you know hot to fix this error?

Thanks,
Charles

@Daviot
Copy link

Daviot commented Oct 11, 2023

@charlesh21 The issue is that a new dependency "call-bind" has been introduced in version 2.3.10 with the commit 3fc8de1, but it is missing in the package.json.

I had the same issue and resolved it by installing call-bin in my project directly.
Just add "call-bind": "^1" to your package.json or install it with npm install call-bind

Hope it helps

@charlesh21
Copy link
Author

Hi @Daviot

Yes, I already added the call-bind into my project package.json as a temp fix.

Thanks

@LudovicSterlin
Copy link

LudovicSterlin commented Oct 11, 2023

Yes same issue here.
Just submitted an MR #2

@Marak
Copy link

Marak commented Oct 11, 2023

:-)

Good morning.

This somehow sync'd up with us today. Friendly reminded to lock package versions if you depend on them.

@jan-molak
Copy link

jan-molak commented Oct 11, 2023

Hi @ljharb, it looks like the latest version of through has a missing dependency on call-bind.

This prevents inquirer from running (see SBoudrias/Inquirer.js#1317) and affects all the projects that rely on it, including WebdriverIO webdriverio/webdriverio#11399:

[wdio] Error: Cannot find module 'call-bind'
[wdio] Require stack:
[wdio] - /Users/example/tmp/node_modules/@ljharb/through/index.js
[wdio]     at Module._resolveFilename (node:internal/modules/cjs/loader:1077:15)
[wdio]     at Module._load (node:internal/modules/cjs/loader:922:27)
[wdio]     at Module.require (node:internal/modules/cjs/loader:1143:19)
[wdio]     at require (node:internal/modules/cjs/helpers:119:18)
[wdio]     at Object.<anonymous> (/Users/example/tmp/node_modules/@ljharb/through/index.js:4:16)
[wdio]     at Module._compile (node:internal/modules/cjs/loader:1256:14)
[wdio]     at Module._extensions..js (node:internal/modules/cjs/loader:1310:10)
[wdio]     at Module.load (node:internal/modules/cjs/loader:1119:32)
[wdio]     at Module._load (node:internal/modules/cjs/loader:960:12)
[wdio]     at ModuleWrap.<anonymous> (node:internal/modules/esm/translators:169:29)
[wdio]     at ModuleJob.run (node:internal/modules/esm/module_job:194:25) {
[wdio]   code: 'MODULE_NOT_FOUND',

I believe that PR #2 and a new release of through should resolve this issue.

Thanks!

@ljharb
Copy link
Owner

ljharb commented Oct 11, 2023

Whoops, thanks. I’ll have a fix published shortly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants