Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TamTam Micro : Piano Color keys dont work when pressed near Black keys. #1206

Closed
kanishkcs opened this issue Feb 27, 2023 · 4 comments
Closed
Labels
enhancement to be release Fixed, to be release
Milestone

Comments

@kanishkcs
Copy link
Contributor

kanishkcs commented Feb 27, 2023

Hey @llaske

I found a bug in the Piano mode of TamTam Activity where the color keys do not work properly when pressed near the black keys area. Specifically, when a color key is pressed above a certain height near the black keys, it does not produce any sound and there is no visual indication of it being pressed. This issue affects multiple keys {Except the 1st and the 7th keys } and significantly impairs the usability of the application.

For the 7th key , it works at the edge of the button but not near the black keys.

Steps to Reproduce :

Open the Piano mode in TamTam Activity.
Click on any Colorfull key in the top section near the black keys.
Notice that the key does not produce any sound and there is no visual indication of it being pressed.

Expected Result:

All keys in the Piano Application should work when clicked, regardless of their position on the keyboard.

Actual Result:

Color keys near the black keys area do not produce any sound and there is no visual indication of them being pressed.

Video

I have added Video showcasing the issue

Color_key_issue.mp4.mp4

Kindly look into this and share your thoughts on this .
So, that i can work on the issue.

@kanishkcs kanishkcs changed the title TamTam Micro : Piano main keys dont work when pressed near Black keys. TamTam Micro : Piano Color keys dont work when pressed near Black keys. Feb 27, 2023
@llaske
Copy link
Owner

llaske commented Feb 27, 2023

You're right. It could be improved.

@kanishkcs
Copy link
Contributor Author

Thanks for the Response @llaske ,
i am working on the fix .

kanishkcs added a commit to kanishkcs/sugarizer that referenced this issue Feb 28, 2023
@kanishkcs
Copy link
Contributor Author

kanishkcs commented Feb 28, 2023

Hey @llaske ,I have fixed the issue Kindly Review the PR #1215

@llaske
Copy link
Owner

llaske commented Feb 28, 2023

Fixed in #1215

@llaske llaske added the to be release Fixed, to be release label Feb 28, 2023
@llaske llaske reopened this Feb 28, 2023
@llaske llaske added this to the v1.7 milestone Mar 28, 2023
@llaske llaske closed this as completed Mar 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement to be release Fixed, to be release
Projects
None yet
Development

No branches or pull requests

2 participants