Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Image selection error in Write activity after scrolling #390

Closed
tk315 opened this issue Oct 13, 2019 · 4 comments
Closed

Image selection error in Write activity after scrolling #390

tk315 opened this issue Oct 13, 2019 · 4 comments
Labels
bug to be release Fixed, to be release
Milestone
v1.3

Comments

@tk315
Copy link

tk315 commented Oct 13, 2019

WHEN I WAS SCROLLING AFTER SELECTING THE IMAGE . I FOUND THIS BUG
writeactivity
@ashish0910
Copy link
Contributor

@tk315 can you please create a pull request for its fix ?
Just add this
this.quill.root.addEventListener('scroll', this.hide, false);
Below this and produce new minified file and replace it with current file here

@llaske llaske added the bug label Oct 13, 2019
@llaske llaske changed the title found a bug in write activity Image selection error in Write activity after scrolling Oct 13, 2019
@tk315
Copy link
Author

tk315 commented Oct 13, 2019

@ashish0910 I had done the suggested changes in ImageResize.js and also created a pull request
Capture12
now what i have to do with minified file ? Will you please ellaborate it ?

@ashish0910
Copy link
Contributor

@tk315 replace current file here with the new minified file and create a pr for it on this repository .

silent-lad added a commit to silent-lad/sugarizer that referenced this issue Oct 18, 2019
@silent-lad
image-resize.min.js updated Fixes llaske#390
c0fcf97
@silent-lad silent-lad mentioned this issue Oct 18, 2019
Closed
@silent-lad silent-lad mentioned this issue Oct 18, 2019
Merged
@llaske llaske added the to be release Fixed, to be release label Oct 21, 2019
@llaske
Copy link
Owner

llaske commented Oct 21, 2019

Fixed in #394

felipebrunetti94 pushed a commit to felipebrunetti94/sugarizer that referenced this issue Nov 18, 2019
@silent-lad @felipebrunetti94
image-resize.min.js updated Fixes llaske#390
a95c591
deadnamedimmer pushed a commit to deadnamedimmer/sugarizer that referenced this issue Dec 23, 2019
@silent-lad @deadnamedimmer
image-resize.min.js updated Fixes llaske#390
26a968b
@llaske llaske added this to the v1.3 milestone Mar 11, 2020
@llaske llaske closed this as completed in 5762d6d Mar 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug to be release Fixed, to be release
Projects
None yet
Milestone
v1.3
Development

Successfully merging a pull request may close this issue.

image-resize.min.js updated Fixes #390 silent-lad/sugarizer
3 participants
@llaske @ashish0910 @tk315