Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature to add a background to Shared Notes activity #799

Closed
4 tasks
llaske opened this issue May 8, 2020 · 5 comments
Closed
4 tasks

Feature to add a background to Shared Notes activity #799

llaske opened this issue May 8, 2020 · 5 comments
Labels
enhancement to be release Fixed, to be release
Milestone

Comments

@llaske
Copy link
Owner

llaske commented May 8, 2020

It could be nice to add a feature to set the background of the Shared Notes activity.
Currently the background is just white.

image

This new feature should:

  • Add a new icon in the toolbar to select the background from the Journal
  • Set the image as the background
  • Handle resizing of the background image when the board is resized
  • Handle record of the background image when the board is save in the Journal.
@ricknjacky
Copy link
Contributor

ricknjacky commented Dec 18, 2020

@llaske I have tried my hand at this, the new behavior is:-

ezgif-2-d9e580314f83

I am not sure if this matches the expected behavior. As you can see at the end when I add note two notes get added, I am kind of stuck as to why that is happening ;-; I fondly anticipate your feedback on this and guidance on how to troubleshoot that error.

@llaske
Copy link
Owner Author

llaske commented Dec 19, 2020

I don't think two notes are added. It look like the control use to set input text is not at the right place: both should be at the same place.

@ricknjacky
Copy link
Contributor

Adding a background and Handling of zoom I've already shared in the previous comment.
Coming to the issue of drag, I had this misconception of dragging the image inside of canvas, hence the grey area in previous comment's gif.

Sugar

Does this now satisfy the behavior expected?

@llaske
Copy link
Owner Author

llaske commented Dec 20, 2020

The grey area is not an issue. It's normal to have a grey (or white) area at some point when the board is moved outside the background image. But the background should move when board is moved.

@llaske
Copy link
Owner Author

llaske commented Jan 27, 2021

Fixed in #914

@llaske llaske added the to be release Fixed, to be release label Jan 27, 2021
@llaske llaske added this to the v1.5 milestone Apr 26, 2021
@llaske llaske closed this as completed Apr 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement to be release Fixed, to be release
Projects
None yet
Development

No branches or pull requests

2 participants