Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature to add a background to Shared Notes activity #801

Closed
wants to merge 3 commits into from

Conversation

sarthak-g
Copy link
Contributor

Fixed #799

This new feature should:

  • Add a new icon in the toolbar to select the background from the Journal
  • Set the image as the background
  • Handle resizing of the background image when the board is resized
  • Handle record of the background image when the board is save in the Journal.

@llaske
Copy link
Owner

llaske commented May 11, 2020

Nice.
But the background should be adapted to zoom and move.

@sarthak-g
Copy link
Contributor Author

sarthak-g commented May 12, 2020

But the background should be adapted to zoom and move.

By this mean you mean, on zooming background should also be zoomed?

@llaske
Copy link
Owner

llaske commented May 12, 2020

Yes and it should be set at the background position of the top/left of the board and move when the board is move. Using a background during a meeting is something usual, see for example here. Of course, the image resolution should have a good resolution.

@sarthak-g
Copy link
Contributor Author

ezgif com-video-to-gif (4)
@llaske made required changes
Is this correct?

@llaske
Copy link
Owner

llaske commented May 19, 2020

That's the idea but:

  • The background should move when the canvas is moved. Currently only notes are moved
  • The background sounds limited to initial size of the board whatever the zoom is. The idea is to zoom out, add a background image with a large size, then to zoom in so the background could cover several screen at normal size

Just a detail but the insert image button should be at the left of the remove button in the toolbar.

@sarthak-g
Copy link
Contributor Author

Raised new pull request (#914 )

@sarthak-g sarthak-g closed this Dec 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants