Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Measure Activity to IntroJS #1102

Merged
merged 7 commits into from
Sep 8, 2022
Merged

Move Measure Activity to IntroJS #1102

merged 7 commits into from
Sep 8, 2022

Conversation

EshaanAgg
Copy link
Contributor

Fixes: #1090
I have replaced bootstrap-tour with introJs library in Measure Activity.

Copy link
Contributor

@disha1202 disha1202 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great 👏🏻 But the tutorial is not working as it should.

screen-recorder-sun-sep-04-2022-23-30-45.webm

And also why have you removed bootstrap.min.css file?

activities/Measure.activity/index.html Outdated Show resolved Hide resolved
@EshaanAgg
Copy link
Contributor Author

Also, there seems to be an error in the original bootstrap.min.css that was present in the repository.

Original:
image
Edited:
image

Line number 7879 was earlier background-color: #000\9, which I have now corrected as shown.

@disha1202
Copy link
Contributor

Great!! Thanks @EshaanAgg
Looks good to me 👍🏻

@llaske
Copy link
Owner

llaske commented Sep 6, 2022

@EshaanAgg the title bar is too small and the close button position is wrong.
It's probably related to IntroJS version see others PR on the issue to find a fix.

image

@EshaanAgg
Copy link
Contributor Author

EshaanAgg commented Sep 7, 2022

@llaske Downgraded the version of IntroJS.css as recommended in PR #1096. Please review now.

@llaske
Copy link
Owner

llaske commented Sep 7, 2022

That's fine now but the test.css file should not be there, it seems to be a dummy file.

@EshaanAgg
Copy link
Contributor Author

Removed the same in the new commit.

@llaske llaske merged commit c50bf16 into llaske:dev Sep 8, 2022
@llaske
Copy link
Owner

llaske commented Sep 8, 2022

Nice. Thanks.

@EshaanAgg EshaanAgg deleted the dev branch September 8, 2022 19:45
@EshaanAgg EshaanAgg restored the dev branch September 8, 2022 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants