Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replaced bootstrap-tour with introJs tour library in Tangram activity #1107

Closed
wants to merge 4 commits into from

Conversation

abhishek-sultaniya
Copy link
Contributor

Fixes: #1090
Replaced bootstrap-tour with introJs library in Tangram Activity.

@abhishek-sultaniya abhishek-sultaniya changed the base branch from master to dev September 20, 2022 21:53
@llaske
Copy link
Owner

llaske commented Sep 24, 2022

There is lot of change in activity.js not related with the issue (quote replacement, coma added, ...).
You should disable automatic change in your IDE to keep only changes need for the PR.

@abhishek-sultaniya
Copy link
Contributor Author

OK,will take care of this from next time.
In recent commit I have corrected it.

@llaske
Copy link
Owner

llaske commented Sep 25, 2022

I don't see any change 🤔

@abhishek-sultaniya
Copy link
Contributor Author

I have made changes in activity.js file.Should I change indentation in any other file?

@llaske
Copy link
Owner

llaske commented Oct 1, 2022

@abhishek-sultaniya I mean this change:

image

@abhishek-sultaniya
Copy link
Contributor Author

abhishek-sultaniya commented Oct 2, 2022

Yes,I have corrected this in last commit.
image
Now its showing only 8 files have been changed and it does not include activity.js

I also checked with original activity.js,its matching.

@llaske
Copy link
Owner

llaske commented Oct 4, 2022

@abhishek-sultaniya you're right it's fixed in activity.js.
Could you also fix indentation style in SugarTutorial.js? Was TAB and you replaced it by SPACES.

@llaske
Copy link
Owner

llaske commented Jan 4, 2023

Close due to lack of activity. @abhishek-sultaniya feel free to reopen it if need.

@llaske llaske closed this Jan 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace Bootstrap tour by IntroJS in tutorial for all activities
2 participants