Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replaced bootstrap tour with IntroJs for Abecedarium #1113

Merged
merged 2 commits into from
Nov 19, 2022
Merged

Replaced bootstrap tour with IntroJs for Abecedarium #1113

merged 2 commits into from
Nov 19, 2022

Conversation

UtkarshSiddhpura
Copy link
Contributor

Fixes #1090 for Abecedarium.

@UtkarshSiddhpura UtkarshSiddhpura changed the base branch from master to dev November 16, 2022 18:42
llaske
llaske reviewed Nov 16, 2022
View reviewed changes
Copy link
Owner

@llaske llaske left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is now a permanent scrollbar to the right of the window.

Capture d’écran du 2022-11-16 22-01-28

activities/Abecedarium.activity/lib/tutorial.js Outdated Show resolved Hide resolved
@UtkarshSiddhpura
Copy link
Contributor Author

@llaske I've fixed the issue Kindly check it

@UtkarshSiddhpura UtkarshSiddhpura changed the title Replaced bootstrap tour with IntroJs for Abecedarium #1090 Replaced bootstrap tour with IntroJs for Abecedarium Nov 18, 2022
@llaske
Copy link
Owner

llaske commented Nov 18, 2022 •
edited
Loading

There is still an issue, the Done button should not be there.
On the last step, the Next button is grayed.

image

@UtkarshSiddhpura
Copy link
Contributor Author

UtkarshSiddhpura commented Nov 19, 2022 •
edited
Loading

@llaske
Fixed now

@llaske llaske merged commit 6217556 into llaske:dev Nov 19, 2022
@llaske
Copy link
Owner

llaske commented Nov 19, 2022

Nice. Thanks.

@UtkarshSiddhpura UtkarshSiddhpura deleted the Abecedarium_IntroJS branch November 19, 2022 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@llaske llaske llaske left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Replace Bootstrap tour by IntroJS in tutorial for all activities
2 participants
@UtkarshSiddhpura @llaske