Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replaced bootstrap-tour with introJs tour library in calculate Activity #1114

Merged
merged 4 commits into from
Nov 20, 2022

Conversation

Ayeshashaik759
Copy link
Contributor

I have migrated calculate activity tutorial from bootstrap-tour to IntroJs
Issue: #1090

@llaske
Copy link
Owner

llaske commented Nov 18, 2022

The title bar has not the right color.

image
image

@Ayeshashaik759
Copy link
Contributor Author

hlo @llaske I made the changes you mentioned please review it once

Screenshot (48)

@llaske
Copy link
Owner

llaske commented Nov 19, 2022

That's better for the title color but there is now a non expected horizontal line between text and buttons.
Try to retrieve the same styles than in others activities migrated to IntroJS.

image

@Ayeshashaik759
Copy link
Contributor Author

Ayeshashaik759 commented Nov 19, 2022

Actually I retrieved the same styles as in other activities migrated to introJS but still got this changes in styles. Now I repeated the same process as you said hope it works correctly this time.

Screenshot (50)

@llaske llaske merged commit 1f878fd into llaske:dev Nov 20, 2022
@llaske
Copy link
Owner

llaske commented Nov 20, 2022

Nice. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants