Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dollar activity Bootstrap Tour to IntroJS Tour #1236

Closed
wants to merge 2 commits into from

Conversation

VedantSharma11
Copy link
Contributor

hey @llaske
I have Replaced Bootstrap tour with intro JS tour. please review
issue:#1090

image

@llaske
Copy link
Owner

llaske commented Mar 2, 2023

Your PR include both change in DollarStreet and in Flip activity. Please do not mix change in PR.

@VedantSharma11
Copy link
Contributor Author

@llaske actually i have made 2 PR first is for flip activity (LINK: #1231) in this i have changed code for just the flip activity and then i created PR for dollar activity merged with flip. So pls review my flip activity first

@llaske
Copy link
Owner

llaske commented Mar 2, 2023

@VedantSharma11 Look like you've closed the PR regarding Flip: #1227
A good practice is to create a different branch for each PR.

@VedantSharma11
Copy link
Contributor Author

Alright @llaske I am closing this PR and making a new one with a different branch

@VedantSharma11 VedantSharma11 deleted the dollarActivity branch March 3, 2023 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants