Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added pause functionality to Blockrain activity #1501

Merged
merged 5 commits into from
Jan 30, 2024

Conversation

VishnuVardhanBR
Copy link
Contributor

Fixes #1499

Screenshot

Any feedback? @llaske

@llaske
Copy link
Owner

llaske commented Jan 20, 2024

Few remarks:

  • At start, the button should be Play
    image

  • Use the play/pause icon from Fraction activity

  • The play/pause button should be before the change theme button

@VishnuVardhanBR
Copy link
Contributor Author

Pushed a commit according to the mentioned changes. Also made a change so that the user can start the game from the play button in toolbar or in the main screen, is this fine @llaske ?

@llaske
Copy link
Owner

llaske commented Jan 23, 2024

  • It should not be possible to use move/flip buttons when the game is paused
  • The help tutorial should be updated to mention the new button

@VishnuVardhanBR
Copy link
Contributor Author

Made changes, could you please check @llaske ?

@llaske
Copy link
Owner

llaske commented Jan 27, 2024

  • At end of the game the button should become Play and allow to replay the game

image

@VishnuVardhanBR
Copy link
Contributor Author

Pushed a commit, could you please check @llaske ?

@llaske llaske merged commit 0f16df2 into llaske:dev Jan 30, 2024
@llaske
Copy link
Owner

llaske commented Jan 30, 2024

Nice. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants