Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#292: Languages in "Language settings" should be non-translated. #293

Merged
merged 1 commit into from
Mar 17, 2019

Conversation

YJDave
Copy link
Contributor

@YJDave YJDave commented Mar 12, 2019

Languages list in User settings->Language settings should
be non-translated to local-browser language.
Fixes issue #292
Now:
If local language is English:
image

If local language is French:
image

In () it shows language name translated to local language and without () it shows original language name without being translated to any other language.

This is my first contribution, so please let me know your feedback.

Languages list in User settings->Language settings should
be non-translated to local-browser language.
@sum2it
Copy link

sum2it commented Mar 12, 2019

The idea of using ( ... ) is interesting.
Seems more user friendly than the previous convention.

@YJDave
Copy link
Contributor Author

YJDave commented Mar 12, 2019

Thanks @sum2it for the feedback :)
It is surely more easy to understand comparing to previous one, as it shows list in both languages(local one and its original).

@llaske llaske merged commit 0cd4903 into llaske:dev Mar 17, 2019
@llaske
Copy link
Owner

llaske commented Mar 17, 2019

Thanks.

@NikhilM98
Copy link

NikhilM98 commented Mar 18, 2019

@YJDave @llaske I think it'll be nice to implement this in Sugarizer-Server too.

@ashish0910
Copy link
Contributor

@NikhilM98 agreed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants