QR code History case sensitive #339
Conversation
| @@ -38,7 +38,6 @@ define(["sugar-web/activity/activity","sugar-web/datastore", "sugar-web/env", "w | |||
| var generateCode = function(text) { | |||
| qrCode.clear(); | |||
| qrCode.makeCode(text); | |||
| var text = userText.value.toLowerCase(); | |||
There was a problem hiding this comment.
I think removing the toLowerCase is not the solution else the following line will not be able to detect string like "HTTP://" or "HttPs://". The solution is just to put the raw value in history.
|
I was actually working on this. Anyway, as lionel mentioned, removing the lowercase condition isn't the answer. |
Sorry @Scar26 if that was the case . However from next time please let other fellow contributors know that you are working on an issue as you did not mention anywhere that you are working on this and I did not found any PR from your side to solve that issue . |
|
@llaske it should work now |
|
Nice. Thanks. |
|
@ashish0910, @Scar26, thanks for your contribution. Yes, it can be helpful to signal that you are working on something, but that does not stop anyone else from working on the same thing. Signal is usually not mandatory. What matters most is the problem is fixed. The value decisiveness part of the code of conduct. For trivial fixes, the investment is small, the solution obvious, and immediately accepted. So the chances of a sense of wasted effort is lower. For complex fixes, the investment can be large, the solutions diverse, and as a result maintainers (such as @llaske) may pick from more than one person. Again, the chances of a sense of wasted effort is lower. In the open source environment, we expect your changes to be copied by others. |
This pr solves the issue mentioned here
Earlier the history content was case insensitive but QR code were case sensitive . In this PR history is also made case sensitive
Current:
Expected: