Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Firefox view fix in grid paint activity #343

Closed
wants to merge 2 commits into from
Closed

Firefox view fix in grid paint activity #343

wants to merge 2 commits into from

Conversation

ashish0910
Copy link
Contributor

This pull request fixes #342
Firefox:

Screenshot 2019-04-12 at 6 34 21 PM

Chrome:

Screenshot 2019-04-12 at 6 43 13 PM

@llaske
Copy link
Owner

llaske commented Apr 16, 2019

That's better but it's not centered.

Capture d’écran de 2019-04-16 22-37-35

@ashish0910
Copy link
Contributor Author

@llaske this should work now

@llaske
Copy link
Owner

llaske commented Apr 17, 2019

It's better for the UI but your change broke the click detection.
When you click on a triangle it's the triangle to the right who get the new color.
To reproduce the issue:

  • Launch the activity
  • Paint few triangle
  • Resize the window (reduce size)
  • Try to paint few triangle

@ashish0910 ashish0910 closed this Nov 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ashish0910 @llaske