Fix Issue #409 #464
Merged
Fix Issue #409 #464
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On user click, the activity becomes fullscreen/unfullscreen.
Image will be added to the buttons. Also added extra css to unfullscreen button to render it well on fullscreen mode.
Added the HTML button tags for fullscreen/unfullscreen buttons.
On fullscreen mode, the main toolbar is not displayed, and the whole activity canvas is moved up and the height is fully extended.
|
It's a good start but there is an error in console: Look like you don't call the right function to recompute size. |
I replaced "TamTam.App.computeResize()" into "app.computeResize()" instead.
I moved the unfullscreen button to avoid accidentally stopping the activity on double click.
|
I've replaced the function call and adjusted the position of the unfullscreen button on this new changes. Let me know if there are still some issues! |
|
Good job Andrea, as usual. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TamTam Micro Activity can now be made into fullscreen mode. This should fix #409