Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixed speak text button and made it responsive. #728

Merged
merged 10 commits into from
Mar 23, 2020
Merged

fixed speak text button and made it responsive. #728

merged 10 commits into from
Mar 23, 2020

Conversation

Swayamsvk
Copy link

fixed #727
speak1

@Swayamsvk
Copy link
Author

@llaske please review this PR

llaske
llaske requested changes Mar 22, 2020
View reviewed changes
Copy link
Owner

@llaske llaske left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work. Few comments in the code

activities/Speak.activity/css/activity.css Outdated
border: 2px solid #e5e5e5;
}

/* #userText {
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do not let commented code

activities/Speak.activity/index.html Show resolved Hide resolved
@Swayamsvk
Copy link
Author

@llaske I have fixed the indentation please review this PR and if possible merge this

@llaske llaske merged commit a2c5ab3 into llaske:dev Mar 23, 2020
@llaske
Copy link
Owner

llaske commented Mar 23, 2020

Nice. Thanks.

@llaske llaske mentioned this pull request Mar 23, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@llaske llaske llaske approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Swayamsvk @llaske