Migrate uses of bar.dyn_cast<Foo>() to dyn_cast<Foo>(bar)
#394
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
```bash perl -i -pe 's/([^ ]*)\.dyn_cast<([^>]*)>\(\)/llvm::dyn_cast<\2>(\1)/g' **/*.cpp **/*.h **/*.cc ```
|
Thanks for the PR. Usually we Other than that you may need to run clang-format to get the format happy. |
ftynse
approved these changes
Apr 3, 2024
|
A proper version bump will require a few breaking API migrations, so for now I'm working with the pinned LLVM commit, but I will opportunistically migrate as I become more familiar with the project. |
|
Ready for a final check (and someone will need to merge it) |
j2kun
changed the title
.dyn_cast to llvm::dyn_castbar.dyn_cast<Foo>() to dyn_cast<Foo>(bar)
ftynse
approved these changes
Apr 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tried building this with a more recent llvm commit, and saw all these deprecation warnings. Thought as a test PR I could migrate some of them. Note I couldn't migrate all of them without bumping the commit because dyn_cast is not supported for
Affine*Exprat the current pinned commit.