Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SSP] Support OR-Tools-based schedulers in -ssp-schedule #4525

Merged
merged 1 commit into from
Jan 23, 2023

Conversation

jopperm
Copy link
Contributor

@jopperm jopperm commented Jan 10, 2023

No description provided.

@jopperm
Copy link
Contributor Author

jopperm commented Jan 10, 2023

@mikeurbach In principle, this is the mechanic continuation of #4364, but I'd like to bring this up for a quick review. The main challenge here is keeping the code duplication in check during the "double dispatch" (problem kind and algorithm) -- do you maybe see a better approach?

Copy link
Contributor

@mikeurbach mikeurbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, sorry for the delayed review.

@jopperm jopperm merged commit 27bd010 into main Jan 23, 2023
@jopperm jopperm deleted the jopperm/ssp-or-tools branch January 23, 2023 00:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants