[ExportVerilog][Emit] Export emitted files #6728
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nandor
force-pushed
the
dev/nandor/emit-dialect
branch
2 times, most recently
from
ec530d0
to
11f5499
Compare
nandor
force-pushed
the
dev/nandor/emit-emit
branch
from
d615ef4
to
ef7ed09
Compare
nandor
force-pushed
the
dev/nandor/emit-dialect
branch
from
11f5499
to
3086362
Compare
nandor
force-pushed
the
dev/nandor/emit-emit
branch
from
ef7ed09
to
28df435
Compare
uenoku
reviewed
Feb 22, 2024
Comment on lines
6076
to
6097
| // Drop an extraneous \n off the end of the string if present. | ||
| StringRef string = op.getText(); | ||
| if (string.ends_with("\n")) | ||
| string = string.drop_back(); | ||
|
|
||
| // Emit each \n separated piece of the string with each piece properly | ||
| // indented. The convention is to not emit the \n so | ||
| // emitLocationInfoAndNewLine can do that for the last line. | ||
| bool isFirst = true; | ||
|
|
||
| // Emit each line of the string at a time. | ||
| while (!string.empty()) { | ||
| auto lhsRhs = string.split('\n'); | ||
| if (isFirst) | ||
| isFirst = false; | ||
| else { | ||
| ps << PP::end << PP::newline << PP::neverbox; | ||
| } | ||
| ps << PPExtString(lhsRhs.first); | ||
| string = lhsRhs.second; | ||
| } | ||
|
|
There was a problem hiding this comment.
Can we avoid code duplication with SV verbatim op emission?
nandor
force-pushed
the
dev/nandor/emit-dialect
branch
from
3086362
to
6e72558
Compare
seldridge
approved these changes
Feb 24, 2024
Comment on lines
6076
to
6097
| // Drop an extraneous \n off the end of the string if present. | ||
| StringRef string = op.getText(); | ||
| if (string.ends_with("\n")) | ||
| string = string.drop_back(); | ||
|
|
||
| // Emit each \n separated piece of the string with each piece properly | ||
| // indented. The convention is to not emit the \n so | ||
| // emitLocationInfoAndNewLine can do that for the last line. | ||
| bool isFirst = true; | ||
|
|
||
| // Emit each line of the string at a time. | ||
| while (!string.empty()) { | ||
| auto lhsRhs = string.split('\n'); | ||
| if (isFirst) | ||
| isFirst = false; | ||
| else { | ||
| ps << PP::end << PP::newline << PP::neverbox; | ||
| } | ||
| ps << PPExtString(lhsRhs.first); | ||
| string = lhsRhs.second; | ||
| } | ||
|
|
nandor
force-pushed
the
dev/nandor/emit-dialect
branch
from
6e72558
to
c13394f
Compare
nandor
force-pushed
the
dev/nandor/emit-emit
branch
from
28df435
to
4460d41
Compare
|
I didn't factor out the common functionality with verbatim since I wanted to avoid adding some rather complex helpers. Instead, I replaced the body in verbatim emission with a shorter implementation that works. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.