[Ibis] Split ContainerOp in two #6739
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In order to not abuse symbol tables, create an OuterContainerOp for top-level containers, and InnerContainerOp for nested containers. The former has a symbol and is an InnerSymbolTable. The latter has an InnerSymbol. Fixes #6658.
blakep-msft
approved these changes
Feb 23, 2024
mortbopet
reviewed
Feb 24, 2024
|
Nice, thanks for addressing this @teqdruid! |
mortbopet
added a commit
that referenced
this pull request
Apr 4, 2024
* Revert "[Ibis] Split ContainerOp in two (#6739)" This reverts commit d17f2f1. * [Ibis] Introduce 'ibis.design' Encapsulate everything into a new op. It's an InnerSymbolTable so that we can identify _everything_ with inner symbols. Partial progress. * Hopefully avoid some msvc warnings * add topLevel attr to containerop * bug fixes * Nest createContainerizePass inside of <ibis::DesignOp> * Work * Work * Working * Self review --------- Co-authored-by: Blake Pelton <blakep@microsoft.com> Co-authored-by: Morten Borup Petersen <morten_bp@live.dk>
cepheus69
pushed a commit
to cepheus69/circt
that referenced
this pull request
Apr 22, 2024
* Revert "[Ibis] Split ContainerOp in two (llvm#6739)" This reverts commit d17f2f1. * [Ibis] Introduce 'ibis.design' Encapsulate everything into a new op. It's an InnerSymbolTable so that we can identify _everything_ with inner symbols. Partial progress. * Hopefully avoid some msvc warnings * add topLevel attr to containerop * bug fixes * Nest createContainerizePass inside of <ibis::DesignOp> * Work * Work * Working * Self review --------- Co-authored-by: Blake Pelton <blakep@microsoft.com> Co-authored-by: Morten Borup Petersen <morten_bp@live.dk>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to not abuse symbol tables, create an OuterContainerOp for top-level containers, and InnerContainerOp for nested containers. The former has a symbol and is an InnerSymbolTable. The latter has an InnerSymbol.
Fixes #6658.