[FIRRTL] Dedup: record less indices when hashing #7816
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We map operations to their index as they appear in the IR, so that we can use the index when hashing their uses as operands and inner-symbol references. We only need to bother assigning indices to operations which actually have results or an inner-symbol. Technically we can do a little better, the result or symbol has to actually have a user, but we we don't have many trivially dead expressions on our input.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We map operations to their index as they appear in the IR, so that we can use the index when hashing their uses as operands and inner-symbol references. We only need to bother assigning indices to operations which actually have results or an inner-symbol. Technically we can do a little better, the result or symbol has to actually have a user, but we we don't have many trivially dead expressions on our input.