Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ExportVerilog] Do not inline non-procedural continuous assignments to variables #7817

Merged
merged 1 commit into from
Nov 14, 2024

Conversation

fzi-hielscher
Copy link
Contributor

The problem has been noted in #6317. I ran into it when writing a SV lowering for sim.triggered, where it caused incorrect behavior.

This PR is a hot-fix to specifically prevent illegal inlining of non-procedural continuous assignments to LogicOps.

@fzi-hielscher fzi-hielscher added bug Something isn't working ExportVerilog labels Nov 14, 2024
Copy link
Member

@uenoku uenoku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@fzi-hielscher fzi-hielscher merged commit e666347 into llvm:main Nov 14, 2024
4 checks passed
@fzi-hielscher fzi-hielscher deleted the npca-inline branch November 14, 2024 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working ExportVerilog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants