Skip to content

Commit

Permalink
[Reproducers] Disable registering lldb::thread_t everywhere
Browse files Browse the repository at this point in the history
As discussed on the mailing list, default serialization for thread ids
is not correct, even if they're represented as basic types. I'm
purposely leaving the corresponding record macros in place so that we
don't break the API boundary detection.

llvm-svn: 355610
  • Loading branch information
JDevlieghere committed Mar 7, 2019
1 parent 6f7c536 commit 0ccc0b1
Showing 1 changed file with 0 additions and 11 deletions.
11 changes: 0 additions & 11 deletions lldb/source/API/SBReproducer.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -1116,17 +1116,6 @@ SBRegistry::SBRegistry() {
LLDB_REGISTER_STATIC_METHOD(lldb::SBFileSpec, SBHostOS,
GetUserHomeDirectory, ());
LLDB_REGISTER_STATIC_METHOD(void, SBHostOS, ThreadCreated, (const char *));
#ifndef _WIN32
// FIXME: On Windows, lldb::thread_t is just a void*, so the we will try to
// allocate an object of type void when deserializing.
LLDB_REGISTER_STATIC_METHOD(bool, SBHostOS, ThreadCancel,
(lldb::thread_t, lldb::SBError *));
LLDB_REGISTER_STATIC_METHOD(bool, SBHostOS, ThreadDetach,
(lldb::thread_t, lldb::SBError *));
LLDB_REGISTER_STATIC_METHOD(
bool, SBHostOS, ThreadJoin,
(lldb::thread_t, lldb::thread_result_t *, lldb::SBError *));
#endif
}
{
LLDB_REGISTER_CONSTRUCTOR(SBInstruction, ());
Expand Down

0 comments on commit 0ccc0b1

Please sign in to comment.