-
Notifications
You must be signed in to change notification settings - Fork 12.3k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[mlir][test] Extend CMake logic for e2e tests
Adds two new CMake functions to query the host system: * `check_hwcap`, * `check_emulator`. Together, these functions are used to check whether a given set of MLIR integration tests require an emulator. If yes, then the corresponding CMake var that defies the required emulator executable is also checked. `check_hwcap` relies on ELF_HWCAP for discovering CPU features from userspace on Linux systems. This is the recommended approach for Arm CPUs running on Linux as outlined in this blog post: * https://community.arm.com/arm-community-blogs/b/operating-systems-blog/posts/runtime-detection-of-cpu-features-on-an-armv8-a-cpu Other operating systems (e.g. Android) and CPU architectures will most likely require some other approach. Right now these new hooks are only used for SVE and SME integration tests. This relands #86489 with the following changes: * Replaced: `set(hwcap_test_file ${CMAKE_BINARY_DIR}/${CMAKE_FILES_DIRECTORY}/hwcap_check.c)` with: `set(hwcap_test_file ${CMAKE_BINARY_DIR}/temp/hwcap_check.c)` The former would trigger an infinite loop when running `ninja` (after the initial CMake configuration). * Fixed commit msg. Previous one was taken from the initial GH PR commit rather than the final re-worked solution (missed this when merging via GH UI). * A couple more NFCs/tweaks.
- Loading branch information
1 parent
aff197f
commit 5ed60ff
Showing
3 changed files
with
115 additions
and
1 deletion.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,100 @@ | ||
# A collection of helper CMake functions to detect hardware capabilities. At | ||
# the moment these are used when configuring MLIR integration tests. | ||
|
||
# Checks whether the specified hardware capability is supported by the host | ||
# Linux system. This is implemented by checking auxiliary vector feature | ||
# provided by the Linux kernel. | ||
# | ||
# check_hwcap( | ||
# hwcap_spec | ||
# output_var | ||
# ) | ||
# | ||
# hwcap_spec - HWCAP value to check - these are defined in hwcap.h in the Linux | ||
# kernel. | ||
# | ||
# output_var - Output variable to use to save the results (TRUE for supported, | ||
# FALSE for not supported). | ||
# | ||
# EXAMPLES: | ||
# | ||
# check_hwcap("HWCAP2_SME" SME_EMULATOR_REQUIRED) | ||
# | ||
function(check_hwcap hwcap_spec output) | ||
set(hwcap_test_src | ||
[====[ | ||
#include <asm/hwcap.h> | ||
#include <sys/auxv.h> | ||
|
||
int main(void) | ||
{ | ||
long hwcaps = getauxval(AT_<HWCAP_VEC>); | ||
return (hwcaps & <HWCAP_SPEC>) != 0; | ||
} | ||
]====] | ||
) | ||
|
||
# Extract from $hwcap_spec whether this is AT_HWCAP or AT_HWCAP2 | ||
string(FIND ${hwcap_spec} "_" wsloc) | ||
string(SUBSTRING ${hwcap_spec} 0 ${wsloc} hwcap_vec) | ||
|
||
string(REPLACE "<HWCAP_VEC>" ${hwcap_vec} hwcap_test_src "${hwcap_test_src}") | ||
string(REPLACE "<HWCAP_SPEC>" ${hwcap_spec} hwcap_test_src "${hwcap_test_src}") | ||
|
||
set(hwcap_test_file ${CMAKE_BINARY_DIR}/temp/hwcap_check.c) | ||
file(WRITE ${hwcap_test_file} "${hwcap_test_src}") | ||
|
||
# Compile _and_ run | ||
try_run( | ||
test_run_result test_compile_result | ||
"${CMAKE_BINARY_DIR}" | ||
"${hwcap_test_file}" | ||
) | ||
# Compilation will fail if hwcap_spec is not defined - this usually means | ||
# that your Linux kernel is too old. | ||
if(${test_compile_result} AND (DEFINED test_run_result)) | ||
message(STATUS "Checking whether ${hwcap_spec} is supported by the host system: ${test_run_result}") | ||
set(${output} ${test_run_result} PARENT_SCOPE) | ||
else() | ||
message(STATUS "Checking whether ${hwcap_spec} is supported by the host system: FALSE") | ||
endif() | ||
endfunction(check_hwcap) | ||
|
||
# For the given group of e2e tests (defined by the `mlir_e2e_tests` flag), | ||
# checks whether an emulator is required. If yes, verifies that the | ||
# corresponding CMake var pointing to an emulator (`emulator_exec`) has been | ||
# set. | ||
# | ||
# check_emulator( | ||
# mlir_e2e_tests | ||
# hwcap_spec | ||
# emulator_exec | ||
# ) | ||
# | ||
# mlir_e2e_tests - MLIR CMake variables corresponding to the group of e2e tests | ||
# to check | ||
# hwcap_spec - HWCAP value to check. This should correspond to the hardware | ||
# capabilities required by the tests to be checked. Possible | ||
# values are defined in hwcap.h in the Linux kernel. | ||
# emulator_exec - variable the defines the emulator (ought to be set if | ||
# required, can be empty otherwise). | ||
# | ||
# EXAMPLES: | ||
# | ||
# check_emulator(MLIR_RUN_ARM_SVE_TESTS "HWCAP_SVE" ARM_EMULATOR_EXECUTABLE) | ||
# | ||
function(check_emulator mlir_e2e_tests hwcap_spec emulator_exec) | ||
if (NOT ${mlir_e2e_tests}) | ||
return() | ||
endif() | ||
|
||
check_hwcap(${hwcap_spec} emulator_not_required) | ||
if (${emulator_not_required}) | ||
return() | ||
endif() | ||
|
||
if (${emulator_exec} STREQUAL "") | ||
message(FATAL_ERROR "${mlir_e2e_tests} requires an emulator, but ${emulator_exec} is not set") | ||
endif() | ||
|
||
endfunction() |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters