Skip to content

Commit

Permalink
[MCA] Simplify the rounding logic used in TimelineView::printWaitTime…
Browse files Browse the repository at this point in the history
…Entry.

This is related to PR51392.

Before this patch, the timeline view was rounding doubles to the first decimal,
using a logic similar to this:

```
  double AverageTime = (double)Input / CumulativeExecutions;
  double Result = floor((AverageTime * 10) + 0.5) / 10
```

Here, Input and CumulativeExecutions are both unsigned integers.
The last operation is what effectively performs the rounding of AverageTime.

PR51392 has been raised because - under specific -m32 configurations of GCC -
one of the timeline tests reports slighlty different values (due to a different
rounding choice).

This patch tries to minimise the propagation of floating-point error by
hoisting the multiply by 10, so that it is performed on the unsigned.

```
  double AverageTime = (double)(Input * 10) / CumulativeExecutions;
  floor(AverageTime + 0.5) / 10
```

So we are trading a floating point multiply for a integer multiply (which can be
expanded using a simple MUL or using an `ADD + LEA` sequence). This decrease in
floating point operations executed should also help with decreasing the error in
the computation..

Strictly speaking, that computation will always be potentially subject to error
(depending on what values are passed in input). However, this patch should
improve the situation and make bug like PR51392 less frequent.

(cherry picked from commit 45685a1)
  • Loading branch information
adibiagio authored and tstellar committed Aug 11, 2021
1 parent c85a094 commit e4471e7
Showing 1 changed file with 8 additions and 7 deletions.
15 changes: 8 additions & 7 deletions llvm/tools/llvm-mca/Views/TimelineView.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -145,10 +145,11 @@ void TimelineView::printWaitTimeEntry(formatted_raw_ostream &OS,

double AverageTime1, AverageTime2, AverageTime3;
AverageTime1 =
(double)Entry.CyclesSpentInSchedulerQueue / CumulativeExecutions;
AverageTime2 = (double)Entry.CyclesSpentInSQWhileReady / CumulativeExecutions;
AverageTime3 =
(double)Entry.CyclesSpentAfterWBAndBeforeRetire / CumulativeExecutions;
(double)(Entry.CyclesSpentInSchedulerQueue * 10) / CumulativeExecutions;
AverageTime2 =
(double)(Entry.CyclesSpentInSQWhileReady * 10) / CumulativeExecutions;
AverageTime3 = (double)(Entry.CyclesSpentAfterWBAndBeforeRetire * 10) /
CumulativeExecutions;

OS << Executions;
OS.PadToColumn(13);
Expand All @@ -157,18 +158,18 @@ void TimelineView::printWaitTimeEntry(formatted_raw_ostream &OS,
if (!PrintingTotals)
tryChangeColor(OS, Entry.CyclesSpentInSchedulerQueue, CumulativeExecutions,
BufferSize);
OS << format("%.1f", floor((AverageTime1 * 10) + 0.5) / 10);
OS << format("%.1f", floor(AverageTime1 + 0.5) / 10);
OS.PadToColumn(20);
if (!PrintingTotals)
tryChangeColor(OS, Entry.CyclesSpentInSQWhileReady, CumulativeExecutions,
BufferSize);
OS << format("%.1f", floor((AverageTime2 * 10) + 0.5) / 10);
OS << format("%.1f", floor(AverageTime2 + 0.5) / 10);
OS.PadToColumn(27);
if (!PrintingTotals)
tryChangeColor(OS, Entry.CyclesSpentAfterWBAndBeforeRetire,
CumulativeExecutions,
getSubTargetInfo().getSchedModel().MicroOpBufferSize);
OS << format("%.1f", floor((AverageTime3 * 10) + 0.5) / 10);
OS << format("%.1f", floor(AverageTime3 + 0.5) / 10);

if (OS.has_colors())
OS.resetColor();
Expand Down

0 comments on commit e4471e7

Please sign in to comment.