Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SystemZ] Assembler does not recognize symbol@GOTENT syntax #105918

Closed
alexrp opened this issue Aug 24, 2024 · 0 comments · Fixed by #107038
Closed

[SystemZ] Assembler does not recognize symbol@GOTENT syntax #105918

alexrp opened this issue Aug 24, 2024 · 0 comments · Fixed by #107038
Labels
backend:SystemZ

Comments

@alexrp
Copy link
Member

alexrp commented Aug 24, 2024 •
edited
Loading

Happens when assembling glibc start code:

/home/alexrp/Source/zig/lib/libc/glibc/sysdeps/s390/s390-64/crti.S:70:26: error: invalid variant 'GOTENT'
 larl %r1,__gmon_start__@GOTENT
                         ^
/home/alexrp/Source/zig/lib/libc/glibc/sysdeps/s390/s390-64/crti.S:70:32: error: unknown token in expression
 larl %r1,__gmon_start__@GOTENT
                               ^
/home/alexrp/Source/zig/lib/libc/glibc/sysdeps/s390/s390-64/crti.S:70:32: error: unknown token in expression
 larl %r1,__gmon_start__@GOTENT
                               ^

This is with LLVM 18.1.8.
@alexrp alexrp mentioned this issue Aug 24, 2024
Open
alexrp added a commit to alexrp/llvm-project that referenced this issue Sep 3, 2024
@alexrp
[llvm][SystemZ] Recognize @gotent modifier in assembler.
5379a26 
Closes llvm#105918.
@alexrp alexrp mentioned this issue Sep 3, 2024
Merged
alexrp added a commit to alexrp/llvm-project that referenced this issue Sep 3, 2024
@alexrp
[llvm][SystemZ] Recognize @gotent modifier in assembler.
65e1543 
Closes llvm#105918.
uweigand pushed a commit that referenced this issue Sep 5, 2024
@alexrp
[llvm][SystemZ] Recognize @GOTENT modifier in assembler. (#107038)
bedac64 
Closes #105918.

I'm unsure if there are other places that need to be updated for this.
VitaNuo pushed a commit to VitaNuo/llvm-project that referenced this issue Sep 12, 2024
@alexrp @VitaNuo
[llvm][SystemZ] Recognize @GOTENT modifier in assembler. (llvm#107038)
64bcc81 
Closes llvm#105918.

I'm unsure if there are other places that need to be updated for this.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
backend:SystemZ
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[llvm][SystemZ] Recognize @GOTENT modifier in assembler. alexrp/llvm-project
2 participants
@alexrp @EugeneZelenko