TEST 'MemorySanitizer-Unit :: ./Msan-x86_64-Test/MemorySanitizer.fstatat' FAILED

[neilnelson]

Bugzilla Link	50487
Version	12.0
OS	Linux
Blocks	#51489
CC	@tstellar

Extended Description

Obtained this error on Ubuntu 21.04 12.0.1 rc1 release run

******************** TEST 'MemorySanitizer-Unit :: ./Msan-x86_64-Test/MemorySanitizer.fstatat' FAILED ********************
Note: Google Test filter = MemorySanitizer.fstatat
[==========] Running 1 test from 1 test case.
[----------] Global test environment set-up.
[----------] 1 test from MemorySanitizer
[ RUN ] MemorySanitizer.fstatat
/home/nnelson/Documents/llvm-project/llvm/utils/release/rc1/llvm-project/compiler-rt/lib/msan/tests/msan_test.cpp:738: Failure
Expected: true
To be equal to: TestForNotPoisoned((st->st_dev))
Which is: false
/home/nnelson/Documents/llvm-project/llvm/utils/release/rc1/llvm-project/compiler-rt/lib/msan/tests/msan_test.cpp:739: Failure
Expected: true
To be equal to: TestForNotPoisoned((st->st_mode))
Which is: false
/home/nnelson/Documents/llvm-project/llvm/utils/release/rc1/llvm-project/compiler-rt/lib/msan/tests/msan_test.cpp:740: Failure
Expected: true
To be equal to: TestForNotPoisoned((st->st_size))
Which is: false
[ FAILED ] MemorySanitizer.fstatat (1 ms)
[----------] 1 test from MemorySanitizer (1 ms total)

[----------] Global test environment tear-down
[==========] 1 test from 1 test case ran. (1 ms total)
[ PASSED ] 0 tests.
[ FAILED ] 1 test, listed below:
[ FAILED ] MemorySanitizer.fstatat

1 FAILED TEST

[neilnelson]

assigned to @vitalybuka

[neilnelson]

Added release-13.0.0 to Blocks field. This bug was seen on the 13.0.0-rc1 release run.

[tstellar]

Evgenii, There are several failures like this reported on Ubuntu. Do you have any idea what the problem might be?

Other similar failures:
#49831
llvm/llvm-bugzilla-archive#50489
llvm/llvm-bugzilla-archive#50490
llvm/llvm-bugzilla-archive#50491
llvm/llvm-bugzilla-archive#50492

[eugenis]

My guess would be something has changed around here:

https://github.com/llvm/llvm-project/blob/main/compiler-rt/lib/msan/msan_interceptors.cpp#L709

we depend on libc internals by intercepting __fxstatat.

[tstellar]

Neil, are you able to reproduce this on other versions of Ubuntu?

[neilnelson]

I will try Ubuntu 20.10 and let you know. After that I can build whatever you think may work well such as Ubuntu 20.04, Xubuntu 20.04.

[neilnelson]

Output from Ubuntu 20.10. Looks much better.

Failed Tests (6):
SanitizerCommon-asan-i386-Linux :: Linux/crypt_r.cpp
SanitizerCommon-asan-i386-Linux :: Posix/crypt.cpp
SanitizerCommon-lsan-i386-Linux :: Linux/crypt_r.cpp
SanitizerCommon-lsan-i386-Linux :: Posix/crypt.cpp
SanitizerCommon-ubsan-i386-Linux :: Linux/crypt_r.cpp
SanitizerCommon-ubsan-i386-Linux :: Posix/crypt.cpp

Testing Time: 743.91s
Skipped : 39
Unsupported : 4859
Passed : 96180
Expectedly Failed: 355
Failed : 6
make[3]: *** [CMakeFiles/check-all.dir/build.make:58: CMakeFiles/check-all] Error 1
make[3]: Target 'CMakeFiles/check-all.dir/build' not remade because of errors.
make[3]: Leaving directory '/home/nnelson/Documents/llvm-project/llvm/utils/release/rc2/Phase3/Release+Asserts/llvmCore-13.0.0-rc2.obj'
make[2]: *** [CMakeFiles/Makefile2:30926: CMakeFiles/check-all.dir/all] Error 2
make[2]: Leaving directory '/home/nnelson/Documents/llvm-project/llvm/utils/release/rc2/Phase3/Release+Asserts/llvmCore-13.0.0-rc2.obj'
make[1]: *** [CMakeFiles/Makefile2:30933: CMakeFiles/check-all.dir/rule] Error 2
make[1]: Target 'check-all' not remade because of errors.
make[1]: Leaving directory '/home/nnelson/Documents/llvm-project/llvm/utils/release/rc2/Phase3/Release+Asserts/llvmCore-13.0.0-rc2.obj'
make: *** [Makefile:264: check-all] Error 2
[Release+Asserts Phase3] check-all failed

[neilnelson]

I was just comparing the output between the two runs.

Ubuntu 20.10
Skipped : 39
Unsupported : 4859
Passed : 96180
Expectedly Failed: 355
Failed : 6

Ubuntu 21.04
Skipped : 39
Unsupported : 4135
Passed : 96933
Expectedly Failed: 355
Failed : 15

It looks like there are more programs checked in 21.04: 96933 - 96180 = 753. Total programs 101477 - 101439 = 38.

[tstellar]

I wonder if there was some glibc change from 20.10 to 21.04 that caused these failures.

[tstellar]

Maybe this?

https://sourceware.org/git/?p=glibc.git;a=commit;h=46c1c765d14c77c6c36df1b51dae6674a4eef06b

[tstellar]

mentioned in issue #51489

[tstellar]

The deadline for requesting fixes for the release has passed. This bug is being removed from the LLVM 13.0.1 release milestone. If you have a fix or think this bug is important enough to block the release, please explain why in a comment and add the bug back to the LLVM 13.0.1 release milestone.