Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[lit] Tests seems to fail in our action #64892

Closed
tru opened this issue Aug 22, 2023 · 4 comments · Fixed by #66799 or llvm/llvm-project-release-prs#707
Closed

[lit] Tests seems to fail in our action #64892

tru opened this issue Aug 22, 2023 · 4 comments · Fixed by #66799 or llvm/llvm-project-release-prs#707
Labels
infrastructure Bugs about LLVM infrastructure tools:llvm-lit
Milestone
LLVM 17.0.X Release

Comments

@tru
Copy link
Collaborator

tru commented Aug 22, 2023

https://github.com/llvm/llvm-project/actions/runs/5936218533/job/16096191390

@tstellar

I ran the tests locally and it seems like locally it failed because FileCheck was not available, do we need to build FileCheck before we run the tests?
@tru tru added infrastructure Bugs about LLVM infrastructure tools:llvm-lit labels Aug 22, 2023
@tru tru added this to the LLVM 17.0.X Release milestone Aug 22, 2023
@github-project-automation github-project-automation bot moved this to Needs Triage in LLVM Release Status Aug 22, 2023
@llvmbot
Copy link
Member

llvmbot commented Aug 22, 2023

@llvm/issue-subscribers-infrastructure

@tuliom tuliom mentioned this issue Sep 19, 2023
Merged
@tru tru moved this from Needs Triage to Needs Merge in LLVM Release Status Sep 25, 2023
tuliom added a commit to tuliom/llvm-project that referenced this issue Sep 25, 2023
@tuliom
workflows/release-tasks: Setup FileCheck and not for release-lit
b64b21f 
lit tests require commands FileCheck and not. They must be available in the PATH.

This also guarantees that python3-psutil is installed in order to enable more tests.

Fixes llvm#64892.
tuliom added a commit that referenced this issue Sep 25, 2023
@tuliom
workflows/release-tasks: Setup FileCheck and not for release-lit (#66799
b2247f8 
)

lit tests require commands FileCheck and not. They must be available in
the PATH.

This also guarantees that python3-psutil is installed in order to enable
more tests.

Fixes #64892.
@tuliom
Copy link
Contributor

tuliom commented Sep 25, 2023

/cherry-pick b2247f8

@llvmbot
Copy link
Member

llvmbot commented Sep 25, 2023

/branch llvm/llvm-project-release-prs/issue64892

@llvmbot llvmbot mentioned this issue Sep 25, 2023
Merged
@llvmbot
Copy link
Member

llvmbot commented Sep 25, 2023

/pull-request llvm/llvm-project-release-prs#707

tru pushed a commit that referenced this issue Sep 27, 2023
@tuliom @tru
workflows/release-tasks: Setup FileCheck and not for release-lit (#66799
b7eba05 
)

lit tests require commands FileCheck and not. They must be available in
the PATH.

This also guarantees that python3-psutil is installed in order to enable
more tests.

Fixes #64892.

(cherry picked from commit b2247f8)
@tru tru moved this from Needs Merge to Done in LLVM Release Status Sep 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
infrastructure Bugs about LLVM infrastructure tools:llvm-lit
Projects
LLVM Release Status
Status: Done
Milestone
LLVM 17.0.X Release
3 participants
@tru @tuliom @llvmbot