Add missing extendhfxf2 in compiler rt #109090
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for submitting a Pull Request (PR) to the LLVM Project! This PR will be automatically labeled and the relevant teams will be notified. If you wish to, you can add reviewers by using the "Reviewers" section on this page. If this is not working for you, it is probably because you do not have write permissions for the repository. In which case you can instead tag reviewers by name in a comment by using If you have received no comments on your PR for a week, you can request a review by "ping"ing the PR by adding a comment “Ping”. The common courtesy "ping" rate is once a week. Please remember that you are asking for valuable time from other developers. If you have further questions, they may be answered by the LLVM GitHub User Guide. You can also ask questions in a comment on this PR, on the LLVM Discord or on the forums. |
|
Object file preview with the change in 34a8124. (Use extendhfxfy to do half->float convertion. Then typecase to long double.) |
|
@overmighty Can you please review this? |
lntue
reviewed
Sep 25, 2024
biabbas
force-pushed
the
extendhfxf2
branch
2 times, most recently
from
815093f to
7272818
Compare
lntue
requested changes
Sep 26, 2024
biabbas
force-pushed
the
extendhfxf2
branch
2 times, most recently
from
d49e7f0 to
fb2e1e0
Compare
|
✅ With the latest revision this PR passed the C/C++ code formatter. |
Can you run clang-format and sync to head to fix buildkite errors? Thanks |
biabbas
force-pushed
the
extendhfxf2
branch
3 times, most recently
from
9658964 to
f0dbc84
Compare
biabbas
force-pushed
the
extendhfxf2
branch
from
f0dbc84 to
7750d70
Compare
lntue
reviewed
Oct 1, 2024
lntue
reviewed
Oct 1, 2024
lntue
reviewed
Oct 1, 2024
lntue
reviewed
Oct 1, 2024
lntue
reviewed
Oct 1, 2024
lntue
approved these changes
Oct 1, 2024
|
@biabbas Congratulations on having your first Pull Request (PR) merged into the LLVM Project! Your changes will be combined with recent changes from other authors, then tested by our build bots. If there is a problem with a build, you may receive a report in an email or a comment on this PR. Please check whether problems have been caused by your change specifically, as the builds can include changes from many authors. It is not uncommon for your change to be included in a build that fails due to someone else's changes, or infrastructure issues. How to do this, and the rest of the post-merge process, is covered in detail here. If your change does cause a problem, it may be reverted, or you can revert it yourself. This is a normal part of LLVM development. You can fix your changes and open a new PR to merge them again. If you don't get any reports, no action is required from you. Your changes are working as expected, well done! |
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/12/builds/6928 Here is the relevant piece of the build log for the reference |
|
@biabbas Look like some extra guards are needed. I'm going to revert the PR and wait for your fix. |
lntue
added a commit
that referenced
this pull request
Oct 1, 2024
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/107/builds/3506 Here is the relevant piece of the build log for the reference |
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/72/builds/3885 Here is the relevant piece of the build log for the reference |
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/146/builds/1287 Here is the relevant piece of the build log for the reference |
puja2196
pushed a commit
to puja2196/LLVM-tutorial
that referenced
this pull request
Oct 2, 2024
VitaNuo
pushed a commit
to VitaNuo/llvm-project
that referenced
this pull request
Oct 2, 2024
Issue: llvm#105181 extendhfxf2 calls extendhfXfy to convert _Float16 to double, then type casts this converted value to long double. __uint128_t may not be available on all architectures. Thus I din't use extendhfXfy to widen precision to 128 bits.
VitaNuo
pushed a commit
to VitaNuo/llvm-project
that referenced
this pull request
Oct 2, 2024
VitaNuo
pushed a commit
to VitaNuo/llvm-project
that referenced
this pull request
Oct 2, 2024
Issue: llvm#105181 extendhfxf2 calls extendhfXfy to convert _Float16 to double, then type casts this converted value to long double. __uint128_t may not be available on all architectures. Thus I din't use extendhfXfy to widen precision to 128 bits.
VitaNuo
pushed a commit
to VitaNuo/llvm-project
that referenced
this pull request
Oct 2, 2024
Sterling-Augustine
pushed a commit
to Sterling-Augustine/llvm-project
that referenced
this pull request
Oct 3, 2024
Issue: llvm#105181 extendhfxf2 calls extendhfXfy to convert _Float16 to double, then type casts this converted value to long double. __uint128_t may not be available on all architectures. Thus I din't use extendhfXfy to widen precision to 128 bits.
Sterling-Augustine
pushed a commit
to Sterling-Augustine/llvm-project
that referenced
this pull request
Oct 3, 2024
xgupta
pushed a commit
to xgupta/llvm-project
that referenced
this pull request
Oct 4, 2024
Issue: llvm#105181 extendhfxf2 calls extendhfXfy to convert _Float16 to double, then type casts this converted value to long double. __uint128_t may not be available on all architectures. Thus I din't use extendhfXfy to widen precision to 128 bits.
xgupta
pushed a commit
to xgupta/llvm-project
that referenced
this pull request
Oct 4, 2024
lntue
pushed a commit
that referenced
this pull request
Oct 26, 2024
Retry pr #109090 with updated extendhfxf2 test
winner245
pushed a commit
to winner245/llvm-project
that referenced
this pull request
Oct 26, 2024
Retry pr llvm#109090 with updated extendhfxf2 test
NoumanAmir657
pushed a commit
to NoumanAmir657/llvm-project
that referenced
this pull request
Nov 4, 2024
Retry pr llvm#109090 with updated extendhfxf2 test
arichardson
added a commit
that referenced
this pull request
Nov 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #105181
extendhfxf2 calls extendhfXfy to convert _Float16 to double, then type casts this converted value to long double.
__uint128_t may not be available on all architectures. Thus I din't use extendhfXfy to widen precision to 128 bits.