[ASan][test] XFAIL Linux/preinstalled_signal.cpp on Linux/sparc64 #109623
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With ASan testing enabled on SPARC as per PR llvm#107405, the ``` AddressSanitizer-sparc-linux-dynamic :: TestCases/Linux/preinstalled_signal.cpp ``` test `FAIL`s on Linux/sparc64. See Issue llvm#109573 for all the details, but the core is that `syscall(__NR_rt_sigaction)` cannot be used because it takes an additional argument that isn't accessible outside of `libc`, while switching to `sigaction` instead changes the order of `AsanInitInternal` and `Init`, breaking the test. Therefore this patch `XFAIL`s the test. Tested on `sparc64-unknown-linux-gnu` and `x86_64-pc-linux-gnu`.
llvmbot
added
compiler-rt
compiler-rt:asan
|
@llvm/pr-subscribers-compiler-rt-sanitizer Author: Rainer Orth (rorth) ChangesWith ASan testing enabled on SPARC as per PR #107405, the test Therefore this patch Tested on Full diff: https://github.com/llvm/llvm-project/pull/109623.diff 1 Files Affected:
diff --git a/compiler-rt/test/asan/TestCases/Linux/preinstalled_signal.cpp b/compiler-rt/test/asan/TestCases/Linux/preinstalled_signal.cpp
index 71929fdd9b37fe..dd31693bc57083 100644
--- a/compiler-rt/test/asan/TestCases/Linux/preinstalled_signal.cpp
+++ b/compiler-rt/test/asan/TestCases/Linux/preinstalled_signal.cpp
@@ -17,6 +17,9 @@
// This way of setting LD_PRELOAD does not work with Android test runner.
// REQUIRES: !android
+// Issue #109573: Cannot use syscall(__NR_rt_sigaction) on Linux/sparc64.
+// XFAIL: target={{sparc.*-.*-linux.*}}
+
#include <assert.h>
#include <signal.h>
#include <stdio.h>
|
vitalybuka
approved these changes
Sep 23, 2024
augusto2112
pushed a commit
to augusto2112/llvm-project
that referenced
this pull request
Sep 26, 2024
…vm#109623) With ASan testing enabled on SPARC as per PR llvm#107405, the ``` AddressSanitizer-sparc-linux-dynamic :: TestCases/Linux/preinstalled_signal.cpp ``` test `FAIL`s on Linux/sparc64. See Issue llvm#109573 for all the details, but the core is that `syscall(__NR_rt_sigaction)` cannot be used because it takes an additional argument that isn't accessible outside of `libc`, while switching to `sigaction` instead changes the order of `AsanInitInternal` and `Init`, breaking the test. Therefore this patch `XFAIL`s the test. Tested on `sparc64-unknown-linux-gnu` and `x86_64-pc-linux-gnu`.
xgupta
pushed a commit
to xgupta/llvm-project
that referenced
this pull request
Oct 4, 2024
…vm#109623) With ASan testing enabled on SPARC as per PR llvm#107405, the ``` AddressSanitizer-sparc-linux-dynamic :: TestCases/Linux/preinstalled_signal.cpp ``` test `FAIL`s on Linux/sparc64. See Issue llvm#109573 for all the details, but the core is that `syscall(__NR_rt_sigaction)` cannot be used because it takes an additional argument that isn't accessible outside of `libc`, while switching to `sigaction` instead changes the order of `AsanInitInternal` and `Init`, breaking the test. Therefore this patch `XFAIL`s the test. Tested on `sparc64-unknown-linux-gnu` and `x86_64-pc-linux-gnu`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With ASan testing enabled on SPARC as per PR #107405, the
test
FAILs on Linux/sparc64. See Issue #109573 for all the details, but the core is thatsyscall(__NR_rt_sigaction)cannot be used because it takes an additional argument that isn't accessible outside oflibc, while switching tosigactioninstead changes the order ofAsanInitInternalandInit, breaking the test.Therefore this patch
XFAILs the test.Tested on
sparc64-unknown-linux-gnuandx86_64-pc-linux-gnu.