Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cmake] Promote message when failing to find compiler-rt to warning #111834

Merged
merged 1 commit into from
Oct 24, 2024

Conversation

ldionne
Copy link
Member

@ldionne ldionne commented Oct 10, 2024

This makes the message stand out a bit more, which can be helpful to debug situations where compiler-rt is missing but shouldn't.

This makes the message stand out a bit more, which can be helpful to
debug situations where compiler-rt is missing but shouldn't.
@ldionne ldionne requested a review from petrhosek October 10, 2024 13:23
@llvmbot llvmbot added the cmake Build system in general and CMake in particular label Oct 10, 2024
@ldionne ldionne merged commit cb445e8 into llvm:main Oct 24, 2024
65 checks passed
@ldionne ldionne deleted the review/handle-compiler-rt-warning branch October 24, 2024 14:27
Copy link
Member

@petrhosek petrhosek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@frobtech frobtech mentioned this pull request Oct 25, 2024
NoumanAmir657 pushed a commit to NoumanAmir657/llvm-project that referenced this pull request Nov 4, 2024
…lvm#111834)

This makes the message stand out a bit more, which can be helpful to
debug situations where compiler-rt is missing but shouldn't.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cmake Build system in general and CMake in particular
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants