Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[lit][aix] Always use internal lit shell on AIX #113355

Merged
merged 1 commit into from
Oct 23, 2024
Merged

Conversation

dpaoliello
Copy link
Contributor

Diff on AIX doesn't have all the required features used in tests (see #108871 and #112997 (comment)), so always use the internal shell.

@llvmbot
Copy link
Member

llvmbot commented Oct 22, 2024

@llvm/pr-subscribers-testing-tools

Author: Daniel Paoliello (dpaoliello)

Changes

Diff on AIX doesn't have all the required features used in tests (see <#108871> and <#112997 (comment)>), so always use the internal shell.


Full diff: https://github.com/llvm/llvm-project/pull/113355.diff

1 Files Affected:

  • (modified) llvm/utils/lit/lit/llvm/config.py (+7)
diff --git a/llvm/utils/lit/lit/llvm/config.py b/llvm/utils/lit/lit/llvm/config.py
index 5f762ec7f3514a..1ef5796cd32e44 100644
--- a/llvm/utils/lit/lit/llvm/config.py
+++ b/llvm/utils/lit/lit/llvm/config.py
@@ -57,6 +57,13 @@ def __init__(self, lit_config, config):
                 self.lit_config.note("using lit tools: {}".format(path))
                 lit_path_displayed = True
 
+        if platform.system() == "AIX":
+            # Diff on AIX doesn't have all the required features (see
+            # https://github.com/llvm/llvm-project/pull/108871 and
+            # https://github.com/llvm/llvm-project/pull/112997#issuecomment-2429656192)
+            # so always use the internal shell.
+            self.use_lit_shell = True
+
         if platform.system() == "OS/390":
             self.with_environment("_BPXK_AUTOCVT", "ON")
             self.with_environment("_TAG_REDIR_IN", "TXT")

Copy link
Contributor

@abhina-sree abhina-sree left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@daltenty daltenty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dpaoliello dpaoliello merged commit 4583dbc into llvm:main Oct 23, 2024
9 of 11 checks passed
@dpaoliello dpaoliello deleted the litaix branch October 23, 2024 19:18
abhina-sree added a commit to abhina-sree/llvm-project that referenced this pull request Oct 24, 2024
@frobtech frobtech mentioned this pull request Oct 25, 2024
NoumanAmir657 pushed a commit to NoumanAmir657/llvm-project that referenced this pull request Nov 4, 2024
Diff on AIX doesn't have all the required features used in tests (see
<llvm#108871> and
<llvm#112997 (comment)>),
so always use the internal shell.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants