-
Notifications
You must be signed in to change notification settings - Fork 12.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[lit][aix] Always use internal lit shell on AIX #113355
Conversation
@llvm/pr-subscribers-testing-tools Author: Daniel Paoliello (dpaoliello) ChangesDiff on AIX doesn't have all the required features used in tests (see <#108871> and <#112997 (comment)>), so always use the internal shell. Full diff: https://github.com/llvm/llvm-project/pull/113355.diff 1 Files Affected:
diff --git a/llvm/utils/lit/lit/llvm/config.py b/llvm/utils/lit/lit/llvm/config.py
index 5f762ec7f3514a..1ef5796cd32e44 100644
--- a/llvm/utils/lit/lit/llvm/config.py
+++ b/llvm/utils/lit/lit/llvm/config.py
@@ -57,6 +57,13 @@ def __init__(self, lit_config, config):
self.lit_config.note("using lit tools: {}".format(path))
lit_path_displayed = True
+ if platform.system() == "AIX":
+ # Diff on AIX doesn't have all the required features (see
+ # https://github.com/llvm/llvm-project/pull/108871 and
+ # https://github.com/llvm/llvm-project/pull/112997#issuecomment-2429656192)
+ # so always use the internal shell.
+ self.use_lit_shell = True
+
if platform.system() == "OS/390":
self.with_environment("_BPXK_AUTOCVT", "ON")
self.with_environment("_TAG_REDIR_IN", "TXT")
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This reverts commit 4583dbc.
Diff on AIX doesn't have all the required features used in tests (see <llvm#108871> and <llvm#112997 (comment)>), so always use the internal shell.
Diff on AIX doesn't have all the required features used in tests (see #108871 and #112997 (comment)), so always use the internal shell.