New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reland "CFIFixup] Factor CFI remember/restore insertion into a helper (NFC)" #113387

Merged

dhoekwater merged 1 commit into llvm:main from dhoekwater:cfi-fixup-refactor

Oct 24, 2024

Contributor

dhoekwater commented Oct 22, 2024

The original patch (ac1a01f) dereferenced an end iterator, breaking some
tests (e.g. https://lab.llvm.org/buildbot/#/builders/17/builds/3116).
This updated patch only accesses the iterator when it's valid.


          Reland "CFIFixup] Factor CFI remember/restore insertion into a helper…

ea4ec96

… (NFC)"

The original patch (ac1a01f) dereferenced an end iterator, breaking some
tests (e.g. https://lab.llvm.org/buildbot/#/builders/17/builds/3116).
This updated patch only accesses the iterator when it's valid.

dhoekwater merged commit 1b8cff9 into llvm:main

9 checks passed

dhoekwater deleted the cfi-fixup-refactor branch

October 24, 2024 21:08

frobtech mentioned this pull request

p/libc fexcept t #113664

Closed

NoumanAmir657 pushed a commit to NoumanAmir657/llvm-project that referenced this pull request


          Reland "CFIFixup] Factor CFI remember/restore insertion into a helper…

0be8de8

… (NFC)" (llvm#113387)

The original patch (ac1a01f) dereferenced an end iterator, breaking some
tests (e.g. https://lab.llvm.org/buildbot/#/builders/17/builds/3116).
This updated patch only accesses the iterator when it's valid.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet