[libc++] Use explicit #include instead of transitive #include #115420
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
llvmbot
added
the
libc++
winner245
changed the title
|
@llvm/pr-subscribers-libcxx Author: Peng Liu (winner245) ChangesThe benchmark test currently uses Full diff: https://github.com/llvm/llvm-project/pull/115420.diff 1 Files Affected:
diff --git a/libcxx/test/benchmarks/vector_operations.bench.cpp b/libcxx/test/benchmarks/vector_operations.bench.cpp
index b0dffe35ec6e14..119f9e16dadc6e 100644
--- a/libcxx/test/benchmarks/vector_operations.bench.cpp
+++ b/libcxx/test/benchmarks/vector_operations.bench.cpp
@@ -14,6 +14,7 @@
#include <deque>
#include <functional>
#include <vector>
+#include <memory>
#include "benchmark/benchmark.h"
|
| @@ -14,6 +14,7 @@ | |||
| #include <deque> | |||
| #include <functional> | |||
| #include <vector> | |||
| #include <memory> | |||
There was a problem hiding this comment.
Currently this file also uses std::string without explictly including <string>. Perhaps we should add #include <string> together.
There was a problem hiding this comment.
Thank you for your reminder. I'll also add that.
philnik777
reviewed
Nov 8, 2024
Comment on lines
14
to
18
| #include <deque> | ||
| #include <functional> | ||
| #include <vector> | ||
| #include <string> | ||
| #include <memory> |
There was a problem hiding this comment.
Suggested change
| #include <deque> | |
| #include <functional> | |
| #include <vector> | |
| #include <string> | |
| #include <memory> | |
| #include <deque> | |
| #include <functional> | |
| #include <memory> | |
| #include <string> | |
| #include <vector> |
There was a problem hiding this comment.
Thanks. I've adjusted the order of headers as per your suggestion.
ldionne
changed the title
philnik777
approved these changes
Nov 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This benchmark test currently uses
std::unique_ptrwithout explicitly#include <memory>. I think we should not rely on transitive inclusion.