[lldb][test] Fix inline_sites_live.cpp Shell when run on Linux remotely from Windows

[dzhidzhoev]

This test fails on https://lab.llvm.org/staging/#/builders/197/builds/76/steps/18/logs/FAIL__lldb-shell__inline_sites_live_cpp because of a little difference in the lldb output.

# .---command stderr------------
# | C:\buildbot\as-builder-10\lldb-x-aarch64\llvm-project\lldb\test\Shell\SymbolFile\NativePDB\inline_sites_live.cpp:25:11: error: CHECK: expected string not found in input
# | // CHECK: * thread #1, stop reason = breakpoint 1
# |           ^
# | <stdin>:1:1: note: scanning from here
# | (lldb) platform select remote-linux
# | ^
# | <stdin>:28:27: note: possible intended match here
# | * thread #1, name = 'inline_sites_li', stop reason = breakpoint 1.3
# |                           ^
# | 

[llvmbot]

@llvm/pr-subscribers-lldb

Author: Vladislav Dzhidzhoev (dzhidzhoev)

Changes

Test fails on https://lab.llvm.org/staging/#/builders/197/builds/76 because of a little difference in format of output.

---

Full diff: https://github.com/llvm/llvm-project/pull/115722.diff

1 Files Affected:

• (modified) lldb/test/Shell/SymbolFile/NativePDB/inline_sites_live.cpp (+2-2)

diff --git a/lldb/test/Shell/SymbolFile/NativePDB/inline_sites_live.cpp b/lldb/test/Shell/SymbolFile/NativePDB/inline_sites_live.cpp
index df6353e28303a3..549bc881b19bb7 100644
--- a/lldb/test/Shell/SymbolFile/NativePDB/inline_sites_live.cpp
+++ b/lldb/test/Shell/SymbolFile/NativePDB/inline_sites_live.cpp
@@ -22,11 +22,11 @@ int main(int argc, char** argv) {
   foo(argc);
 }
 
-// CHECK:      * thread #1, stop reason = breakpoint 1
+// CHECK:      * thread #1, {{.*}}stop reason = breakpoint 1
 // CHECK-NEXT:    frame #0: {{.*}}`main [inlined] bar(param=2)
 // CHECK:      (lldb) expression param
 // CHECK-NEXT: (int) $0 = 2
-// CHECK:      * thread #1, stop reason = breakpoint 2
+// CHECK:      * thread #1, {{.*}}stop reason = breakpoint 2
 // CHECK-NEXT:    frame #0: {{.*}}`main [inlined] foo(param=1)
 // CHECK:      (lldb) expression param
 // CHECK-NEXT: (int) $1 = 1

[labath]

How can you run a PDB test on a linux machine?

[DavidSpickett]

If I understand correctly this is building the test on Linux and running it on Windows.

And it seems that the output is in fact better this way? Can't complain about that.

[DavidSpickett]

I thought maybe the test passed accidentally with this change but the backtrace must still match so LGTM.

[labath]

That might make more sense, but looking at the bot, it really does seem to run on windows, with a remote linux target (I guess it doesn't really run the binary there, it must fall back to host when it find the binary is not compatible). And if I had to guess, I'd say that all of this platform dancing causes it to somehow switch the the lldb-server windows implementation, which sends thread names (unlike the in-process one?).

Overall, I guess the change is fine, though the combination is not particularly useful to test.

[dzhidzhoev]

If I understand correctly this is building the test on Linux and running it on Windows.

And it seems that the output is in fact better this way? Can't complain about that.

No, it's the opposite, we're running on Windows host and Linux target.

And if I had to guess, I'd say that all of this platform dancing causes it to somehow switch the the lldb-server windows implementation, which sends thread names (unlike the in-process one?).

It makes sense. I also thought it was somehow related to remote vs local execution.

Overall, I guess the change is fine, though the combination is not particularly useful to test.

Thank you! Considering that there's "REQUIRES: system-windows" on top of the test, maybe I'll turn it off for target-linux at all?

[labath]

Considering that there's "REQUIRES: system-windows" on top of the test, maybe I'll turn it off for target-linux at all?

This problem is not really linux specific any os!=windows will have the same problem. I think REQUIRES: target-windows would be better.

[dzhidzhoev]

Considering that there's "REQUIRES: system-windows" on top of the test, maybe I'll turn it off for target-linux at all?

This problem is not really linux specific any os!=windows will have the same problem. I think REQUIRES: target-windows would be better.

Thanks! I'll change it.