Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

workflows/build-ci-container: Fix typos in variables #119943

Merged
merged 2 commits into from
Dec 14, 2024

Conversation

tstellar
Copy link
Collaborator

This was preventing the containers from being pushed to the registry.

This was preventing the containers from being pushed to the registry.
@llvmbot
Copy link
Member

llvmbot commented Dec 14, 2024

@llvm/pr-subscribers-github-workflow

Author: Tom Stellard (tstellar)

Changes

This was preventing the containers from being pushed to the registry.


Full diff: https://github.com/llvm/llvm-project/pull/119943.diff

1 Files Affected:

  • (modified) .github/workflows/build-ci-container.yml (+1-1)
diff --git a/.github/workflows/build-ci-container.yml b/.github/workflows/build-ci-container.yml
index f037a91f6e5d01..022aa930051837 100644
--- a/.github/workflows/build-ci-container.yml
+++ b/.github/workflows/build-ci-container.yml
@@ -80,7 +80,7 @@ jobs:
 
       - name: Push Container
         run: |
-          podman load -i ${{ needs.build-ci-container.outptus.container-filename }}
+          podman load -i ${{ needs.build-ci-container.outputs.container-filename }}
           podman tag ${{ steps.vars.outputs.container-name-tag }} ${{ steps.vars.outputs.container-name }}:latest
           podman login -u ${{ github.actor }} -p $GITHUB_TOKEN ghcr.io
           podman push ${{ needs.build-ci-container.outputs.container-name-tag }}

Copy link
Contributor

@boomanaiden154 boomanaiden154 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I saw this with the new windows container job too. I think there are a couple other latent issues from splitting the build and push that need to be fixed though. Give me a little bit of time and I'll have a look.

@tstellar tstellar changed the title workflows/build-ci-container: Fix typo in variable workflows/build-ci-container: Fix typos in variables Dec 14, 2024
Copy link
Contributor

@boomanaiden154 boomanaiden154 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the fix!

@tstellar tstellar merged commit 22266bc into llvm:main Dec 14, 2024
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants