-
Notifications
You must be signed in to change notification settings - Fork 12.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
workflows/build-ci-container: Fix typos in variables #119943
Conversation
This was preventing the containers from being pushed to the registry.
@llvm/pr-subscribers-github-workflow Author: Tom Stellard (tstellar) ChangesThis was preventing the containers from being pushed to the registry. Full diff: https://github.com/llvm/llvm-project/pull/119943.diff 1 Files Affected:
diff --git a/.github/workflows/build-ci-container.yml b/.github/workflows/build-ci-container.yml
index f037a91f6e5d01..022aa930051837 100644
--- a/.github/workflows/build-ci-container.yml
+++ b/.github/workflows/build-ci-container.yml
@@ -80,7 +80,7 @@ jobs:
- name: Push Container
run: |
- podman load -i ${{ needs.build-ci-container.outptus.container-filename }}
+ podman load -i ${{ needs.build-ci-container.outputs.container-filename }}
podman tag ${{ steps.vars.outputs.container-name-tag }} ${{ steps.vars.outputs.container-name }}:latest
podman login -u ${{ github.actor }} -p $GITHUB_TOKEN ghcr.io
podman push ${{ needs.build-ci-container.outputs.container-name-tag }}
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I saw this with the new windows container job too. I think there are a couple other latent issues from splitting the build and push that need to be fixed though. Give me a little bit of time and I'll have a look.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks for the fix!
This was preventing the containers from being pushed to the registry.