Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BOLT][NFC] Refactor BAT metadata data structures #86353

Merged
merged 4 commits into from
Mar 23, 2024
Merged

[BOLT][NFC] Refactor BAT metadata data structures #86353

merged 4 commits into from
Mar 23, 2024

Conversation

aaupov
Copy link
Contributor

@aaupov aaupov commented Mar 22, 2024

Hide the implementations of FuncHashes and BBHashMap classes,
getting rid of at accessors that could throw an exception.

Test Plan: NFC

@aaupov
[𝘀𝗽𝗿] initial version
12a5c6c 
Created using spr 1.3.4
@aaupov aaupov mentioned this pull request Mar 22, 2024
Merged
@github-actions GitHub Actions
Copy link

✅ With the latest revision this PR passed the Python code formatter.

@github-actions GitHub Actions
Copy link

✅ With the latest revision this PR passed the C/C++ code formatter.

@rafaelauler
Copy link
Contributor

How do I navigate these SPR stacks? This goes on top of what?

@aaupov
Copy link
Contributor Author

aaupov commented Mar 22, 2024 •
edited
Loading

How do I navigate these SPR stacks? This goes on top of what?

Unfortunately, there's no way to navigate SPR stacks (that I'm aware of). I'll make it explicit in follow-up diffs what they depend on. This PR is a base.

rafaelauler
rafaelauler approved these changes Mar 22, 2024
View reviewed changes
Copy link
Contributor

@rafaelauler rafaelauler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG

@aaupov aaupov merged commit a91cd53 into main Mar 23, 2024
4 checks passed
@aaupov aaupov deleted the users/aaupov/spr/boltnfc-refactor-bat-metadata-data-structures branch March 23, 2024 23:08
aaupov added a commit that referenced this pull request Mar 23, 2024
@aaupov
Updated on top of #86353
ad0778e 
Created using spr 1.3.4
aaupov added a commit that referenced this pull request Mar 24, 2024
@aaupov
[BOLT] Emit intra-function control flow in YAMLBAT
d7d2f7c 
Attach branch counters to YAML profile, covering intra-function control
flow.

Depends on: #86353

Test Plan: Updated bolt/test/X86/bolt-address-translation-yaml.test

Reviewers: rafaelauler, dcci, ayermolo, maksfb

Reviewed By: rafaelauler

Pull Request: #76911
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rafaelauler rafaelauler rafaelauler approved these changes

@maksfb maksfb Awaiting requested review from maksfb maksfb is a code owner

@ayermolo ayermolo Awaiting requested review from ayermolo ayermolo is a code owner

@dcci dcci Awaiting requested review from dcci dcci is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aaupov @rafaelauler