[libc][math][c23] Add fmodf16 C23 math function #94629

overmighty · 2024-06-06T15:17:25Z

Part of #93566.

overmighty · 2024-06-06T15:17:37Z

cc @lntue

llvmbot · 2024-06-06T15:17:56Z

@llvm/pr-subscribers-libc

Author: OverMighty (overmighty)

Changes

Part of #93566.

Full diff: https://github.com/llvm/llvm-project/pull/94629.diff

13 Files Affected:

(modified) libc/config/linux/aarch64/entrypoints.txt (+1)
(modified) libc/config/linux/x86_64/entrypoints.txt (+1)
(modified) libc/docs/math/index.rst (+1-1)
(modified) libc/spec/stdc.td (+1)
(modified) libc/src/__support/FPUtil/FPBits.h (+1-1)
(modified) libc/src/__support/FPUtil/generic/FMod.h (+3-1)
(modified) libc/src/math/CMakeLists.txt (+1)
(added) libc/src/math/fmodf16.h (+20)
(modified) libc/src/math/generic/CMakeLists.txt (+13)
(added) libc/src/math/generic/fmodf16.cpp (+19)
(modified) libc/test/src/math/smoke/CMakeLists.txt (+25-8)
(modified) libc/test/src/math/smoke/FModTest.h (+19-18)
(added) libc/test/src/math/smoke/fmodf16_test.cpp (+13)

diff --git a/libc/config/linux/aarch64/entrypoints.txt b/libc/config/linux/aarch64/entrypoints.txt
index 13a4445aca76b..d18d35c5120c6 100644
--- a/libc/config/linux/aarch64/entrypoints.txt
+++ b/libc/config/linux/aarch64/entrypoints.txt
@@ -507,6 +507,7 @@ if(LIBC_TYPES_HAS_FLOAT16)
     libc.src.math.floorf16
     libc.src.math.fmaxf16
     libc.src.math.fminf16
+    libc.src.math.fmodf16
     libc.src.math.fromfpf16
     libc.src.math.fromfpxf16
     libc.src.math.llrintf16
diff --git a/libc/config/linux/x86_64/entrypoints.txt b/libc/config/linux/x86_64/entrypoints.txt
index 9db044e953f31..b8c143dca2d49 100644
--- a/libc/config/linux/x86_64/entrypoints.txt
+++ b/libc/config/linux/x86_64/entrypoints.txt
@@ -540,6 +540,7 @@ if(LIBC_TYPES_HAS_FLOAT16)
     libc.src.math.floorf16
     libc.src.math.fmaxf16
     libc.src.math.fminf16
+    libc.src.math.fmodf16
     libc.src.math.fromfpf16
     libc.src.math.fromfpxf16
     libc.src.math.llrintf16
diff --git a/libc/docs/math/index.rst b/libc/docs/math/index.rst
index 8c3c07a35b935..46ca728877ed6 100644
--- a/libc/docs/math/index.rst
+++ b/libc/docs/math/index.rst
@@ -156,7 +156,7 @@ Basic Operations
 +------------------+------------------+-----------------+------------------------+----------------------+------------------------+------------------------+----------------------------+
 | fminimum_num     | |check|          | |check|         | |check|                |                      | |check|                | 7.12.12.9              | F.10.9.5                   |
 +------------------+------------------+-----------------+------------------------+----------------------+------------------------+------------------------+----------------------------+
-| fmod             | |check|          | |check|         | |check|                |                      | |check|                | 7.12.10.1              | F.10.7.1                   |
+| fmod             | |check|          | |check|         | |check|                | |check|              | |check|                | 7.12.10.1              | F.10.7.1                   |
 +------------------+------------------+-----------------+------------------------+----------------------+------------------------+------------------------+----------------------------+
 | fmul             | N/A              |                 |                        | N/A                  |                        | 7.12.14.3              | F.10.11                    |
 +------------------+------------------+-----------------+------------------------+----------------------+------------------------+------------------------+----------------------------+
diff --git a/libc/spec/stdc.td b/libc/spec/stdc.td
index f867a3d27403a..485e947b26571 100644
--- a/libc/spec/stdc.td
+++ b/libc/spec/stdc.td
@@ -470,6 +470,7 @@ def StdC : StandardSpec<"stdc"> {
           FunctionSpec<"fmod", RetValSpec<DoubleType>, [ArgSpec<DoubleType>, ArgSpec<DoubleType>]>,
           FunctionSpec<"fmodf", RetValSpec<FloatType>, [ArgSpec<FloatType>, ArgSpec<FloatType>]>,
           FunctionSpec<"fmodl", RetValSpec<LongDoubleType>, [ArgSpec<LongDoubleType>, ArgSpec<LongDoubleType>]>,
+          GuardedFunctionSpec<"fmodf16", RetValSpec<Float16Type>, [ArgSpec<Float16Type>, ArgSpec<Float16Type>], "LIBC_TYPES_HAS_FLOAT16">,
           GuardedFunctionSpec<"fmodf128", RetValSpec<Float128Type>, [ArgSpec<Float128Type>, ArgSpec<Float128Type>], "LIBC_TYPES_HAS_FLOAT128">,
 
           FunctionSpec<"frexp", RetValSpec<DoubleType>, [ArgSpec<DoubleType>, ArgSpec<IntPtr>]>,
diff --git a/libc/src/__support/FPUtil/FPBits.h b/libc/src/__support/FPUtil/FPBits.h
index d3c96d2d613d6..559ecde767c30 100644
--- a/libc/src/__support/FPUtil/FPBits.h
+++ b/libc/src/__support/FPUtil/FPBits.h
@@ -744,7 +744,7 @@ struct FPRepImpl : public FPRepSem<fp_type, RetT> {
     if (LIBC_LIKELY(ep >= 0)) {
       // Implicit number bit will be removed by mask
       result.set_significand(number);
-      result.set_biased_exponent(ep + 1);
+      result.set_biased_exponent(static_cast<StorageType>(ep + 1));
     } else {
       result.set_significand(number >> -ep);
     }
diff --git a/libc/src/__support/FPUtil/generic/FMod.h b/libc/src/__support/FPUtil/generic/FMod.h
index 211ab926d28b0..f840a92b1a5a2 100644
--- a/libc/src/__support/FPUtil/generic/FMod.h
+++ b/libc/src/__support/FPUtil/generic/FMod.h
@@ -210,7 +210,9 @@ class FMod {
                     e_x - e_y <= int(FPB::EXP_LEN))) {
       StorageType m_x = sx.get_explicit_mantissa();
       StorageType m_y = sy.get_explicit_mantissa();
-      StorageType d = (e_x == e_y) ? (m_x - m_y) : (m_x << (e_x - e_y)) % m_y;
+      StorageType d = (e_x == e_y)
+                          ? (m_x - m_y)
+                          : static_cast<StorageType>(m_x << (e_x - e_y)) % m_y;
       if (d == 0)
         return FPB::zero();
       // iy - 1 because of "zero power" for number with power 1
diff --git a/libc/src/math/CMakeLists.txt b/libc/src/math/CMakeLists.txt
index 498466692fcca..2471c38454d4c 100644
--- a/libc/src/math/CMakeLists.txt
+++ b/libc/src/math/CMakeLists.txt
@@ -175,6 +175,7 @@ add_math_entrypoint_object(fminimum_mag_numf128)
 add_math_entrypoint_object(fmod)
 add_math_entrypoint_object(fmodf)
 add_math_entrypoint_object(fmodl)
+add_math_entrypoint_object(fmodf16)
 add_math_entrypoint_object(fmodf128)
 
 add_math_entrypoint_object(frexp)
diff --git a/libc/src/math/fmodf16.h b/libc/src/math/fmodf16.h
new file mode 100644
index 0000000000000..ab658430275d8
--- /dev/null
+++ b/libc/src/math/fmodf16.h
@@ -0,0 +1,20 @@
+//===-- Implementation header for fmodf16 -----------------------*- C++ -*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
+//
+//===----------------------------------------------------------------------===//
+
+#ifndef LLVM_LIBC_SRC_MATH_FMODF16_H
+#define LLVM_LIBC_SRC_MATH_FMODF16_H
+
+#include "src/__support/macros/properties/types.h"
+
+namespace LIBC_NAMESPACE {
+
+float16 fmodf16(float16 x, float16 y);
+
+} // namespace LIBC_NAMESPACE
+
+#endif // LLVM_LIBC_SRC_MATH_FMODF16_H
diff --git a/libc/src/math/generic/CMakeLists.txt b/libc/src/math/generic/CMakeLists.txt
index c183f09fa5e3d..13b3f60e77014 100644
--- a/libc/src/math/generic/CMakeLists.txt
+++ b/libc/src/math/generic/CMakeLists.txt
@@ -2785,6 +2785,19 @@ add_entrypoint_object(
     -O3
 )
 
+add_entrypoint_object(
+  fmodf16
+  SRCS
+    fmodf16.cpp
+  HDRS
+    ../fmodf16.h
+  DEPENDS
+    libc.src.__support.macros.properties.types
+    libc.src.__support.FPUtil.generic.fmod
+  COMPILE_OPTIONS
+    -O3
+)
+
 add_entrypoint_object(
   fmodf128
   SRCS
diff --git a/libc/src/math/generic/fmodf16.cpp b/libc/src/math/generic/fmodf16.cpp
new file mode 100644
index 0000000000000..0a54a65806de9
--- /dev/null
+++ b/libc/src/math/generic/fmodf16.cpp
@@ -0,0 +1,19 @@
+//===-- Implementation of fmodf16 function --------------------------------===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
+//
+//===----------------------------------------------------------------------===//
+
+#include "src/math/fmodf16.h"
+#include "src/__support/FPUtil/generic/FMod.h"
+#include "src/__support/common.h"
+
+namespace LIBC_NAMESPACE {
+
+LLVM_LIBC_FUNCTION(float16, fmodf16, (float16 x, float16 y)) {
+  return fputil::generic::FMod<float16>::eval(x, y);
+}
+
+} // namespace LIBC_NAMESPACE
diff --git a/libc/test/src/math/smoke/CMakeLists.txt b/libc/test/src/math/smoke/CMakeLists.txt
index 8919b54262b0f..171ff9e41cee0 100644
--- a/libc/test/src/math/smoke/CMakeLists.txt
+++ b/libc/test/src/math/smoke/CMakeLists.txt
@@ -2954,10 +2954,10 @@ add_fp_unittest(
   HDRS
     FModTest.h
   DEPENDS
+    libc.hdr.fenv_macros
     libc.src.errno.errno
     libc.src.math.fmodf
-    libc.src.__support.FPUtil.basic_operations
-    libc.src.__support.FPUtil.nearest_integer_operations
+    libc.src.__support.FPUtil.fenv_impl
   # FIXME: Currently fails on the GPU build.
   UNIT_TEST_ONLY
 )
@@ -2971,10 +2971,10 @@ add_fp_unittest(
   HDRS
     FModTest.h
   DEPENDS
+    libc.hdr.fenv_macros
     libc.src.errno.errno
     libc.src.math.fmod
-    libc.src.__support.FPUtil.basic_operations
-    libc.src.__support.FPUtil.nearest_integer_operations
+    libc.src.__support.FPUtil.fenv_impl
   # FIXME: Currently fails on the GPU build.
   UNIT_TEST_ONLY
 )
@@ -2988,10 +2988,27 @@ add_fp_unittest(
   HDRS
     FModTest.h
   DEPENDS
+    libc.hdr.fenv_macros
     libc.src.errno.errno
     libc.src.math.fmodl
-    libc.src.__support.FPUtil.basic_operations
-    libc.src.__support.FPUtil.nearest_integer_operations
+    libc.src.__support.FPUtil.fenv_impl
+  # FIXME: Currently fails on the GPU build.
+  UNIT_TEST_ONLY
+)
+
+add_fp_unittest(
+  fmodf16_test
+  SUITE
+    libc-math-smoke-tests
+  SRCS
+    fmodf16_test.cpp
+  HDRS
+    FModTest.h
+  DEPENDS
+    libc.hdr.fenv_macros
+    libc.src.errno.errno
+    libc.src.math.fmodf16
+    libc.src.__support.FPUtil.fenv_impl
   # FIXME: Currently fails on the GPU build.
   UNIT_TEST_ONLY
 )
@@ -3005,10 +3022,10 @@ add_fp_unittest(
   HDRS
     FModTest.h
   DEPENDS
+    libc.hdr.fenv_macros
     libc.src.errno.errno
     libc.src.math.fmodf128
-    libc.src.__support.FPUtil.basic_operations
-    libc.src.__support.FPUtil.nearest_integer_operations
+    libc.src.__support.FPUtil.fenv_impl
   # FIXME: Currently fails on the GPU build.
   UNIT_TEST_ONLY
 )
diff --git a/libc/test/src/math/smoke/FModTest.h b/libc/test/src/math/smoke/FModTest.h
index f1015d6497fcd..405e3107438d4 100644
--- a/libc/test/src/math/smoke/FModTest.h
+++ b/libc/test/src/math/smoke/FModTest.h
@@ -9,13 +9,13 @@
 #ifndef LLVM_LIBC_TEST_SRC_MATH_FMODTEST_H
 #define LLVM_LIBC_TEST_SRC_MATH_FMODTEST_H
 
-#include "src/__support/FPUtil/BasicOperations.h"
-#include "src/__support/FPUtil/NearestIntegerOperations.h"
+#include "src/__support/FPUtil/FEnvImpl.h"
+#include "src/errno/libc_errno.h"
 #include "test/UnitTest/FEnvSafeTest.h"
 #include "test/UnitTest/FPMatcher.h"
 #include "test/UnitTest/Test.h"
 
-#include "hdr/math_macros.h"
+#include "hdr/fenv_macros.h"
 
 #define TEST_SPECIAL(x, y, expected, dom_err, expected_exception)              \
   EXPECT_FP_EQ(expected, f(x, y));                                             \
@@ -210,7 +210,8 @@ class FmodTest : public LIBC_NAMESPACE::testing::FEnvSafeTest {
   }
 
   void testRegularExtreme(FModFunc f) {
-
+    if constexpr (sizeof(T) < sizeof(float))
+      return;
     TEST_REGULAR(0x1p127L, 0x3p-149L, 0x1p-149L);
     TEST_REGULAR(0x1p127L, -0x3p-149L, 0x1p-149L);
     TEST_REGULAR(0x1p127L, 0x3p-148L, 0x1p-147L);
@@ -224,20 +225,20 @@ class FmodTest : public LIBC_NAMESPACE::testing::FEnvSafeTest {
     TEST_REGULAR(-0x1p127L, 0x3p-126L, -0x1p-125L);
     TEST_REGULAR(-0x1p127L, -0x3p-126L, -0x1p-125L);
 
-    if constexpr (sizeof(T) >= sizeof(double)) {
-      TEST_REGULAR(0x1p1023L, 0x3p-1074L, 0x1p-1073L);
-      TEST_REGULAR(0x1p1023L, -0x3p-1074L, 0x1p-1073L);
-      TEST_REGULAR(0x1p1023L, 0x3p-1073L, 0x1p-1073L);
-      TEST_REGULAR(0x1p1023L, -0x3p-1073L, 0x1p-1073L);
-      TEST_REGULAR(0x1p1023L, 0x3p-1022L, 0x1p-1021L);
-      TEST_REGULAR(0x1p1023L, -0x3p-1022L, 0x1p-1021L);
-      TEST_REGULAR(-0x1p1023L, 0x3p-1074L, -0x1p-1073L);
-      TEST_REGULAR(-0x1p1023L, -0x3p-1074L, -0x1p-1073L);
-      TEST_REGULAR(-0x1p1023L, 0x3p-1073L, -0x1p-1073L);
-      TEST_REGULAR(-0x1p1023L, -0x3p-1073L, -0x1p-1073L);
-      TEST_REGULAR(-0x1p1023L, 0x3p-1022L, -0x1p-1021L);
-      TEST_REGULAR(-0x1p1023L, -0x3p-1022L, -0x1p-1021L);
-    }
+    if constexpr (sizeof(T) < sizeof(double))
+      return;
+    TEST_REGULAR(0x1p1023L, 0x3p-1074L, 0x1p-1073L);
+    TEST_REGULAR(0x1p1023L, -0x3p-1074L, 0x1p-1073L);
+    TEST_REGULAR(0x1p1023L, 0x3p-1073L, 0x1p-1073L);
+    TEST_REGULAR(0x1p1023L, -0x3p-1073L, 0x1p-1073L);
+    TEST_REGULAR(0x1p1023L, 0x3p-1022L, 0x1p-1021L);
+    TEST_REGULAR(0x1p1023L, -0x3p-1022L, 0x1p-1021L);
+    TEST_REGULAR(-0x1p1023L, 0x3p-1074L, -0x1p-1073L);
+    TEST_REGULAR(-0x1p1023L, -0x3p-1074L, -0x1p-1073L);
+    TEST_REGULAR(-0x1p1023L, 0x3p-1073L, -0x1p-1073L);
+    TEST_REGULAR(-0x1p1023L, -0x3p-1073L, -0x1p-1073L);
+    TEST_REGULAR(-0x1p1023L, 0x3p-1022L, -0x1p-1021L);
+    TEST_REGULAR(-0x1p1023L, -0x3p-1022L, -0x1p-1021L);
   }
 };
 
diff --git a/libc/test/src/math/smoke/fmodf16_test.cpp b/libc/test/src/math/smoke/fmodf16_test.cpp
new file mode 100644
index 0000000000000..9a48c5aa0d609
--- /dev/null
+++ b/libc/test/src/math/smoke/fmodf16_test.cpp
@@ -0,0 +1,13 @@
+//===-- Unittests for fmodf16 ---------------------------------------------===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
+//
+//===----------------------------------------------------------------------===//
+
+#include "FModTest.h"
+
+#include "src/math/fmodf16.h"
+
+LIST_FMOD_TESTS(float16, LIBC_NAMESPACE::fmodf16)

overmighty · 2024-06-06T15:27:24Z

Rebased and resolved merge conflicts.

overmighty · 2024-06-06T18:19:37Z

Performance test on Intel Core i7-13700H:

fputil::generic::FMod<float16, uint16_t>::eval ("My function") vs fputil::generic::FMod<float16, uint32_t>::eval ("Other function"):

 Performance tests with inputs in denormal range:
-- My function --
     Total time      : 31887746 ns 
     Average runtime : 6.23416 ns/op 
     Ops per second  : 160406445 op/s 
-- Other function --
     Total time      : 31818669 ns 
     Average runtime : 6.22066 ns/op 
     Ops per second  : 160754681 op/s 
-- Average runtime ratio --
     Mine / Other's  : 1.00217 

 Performance tests with inputs in normal range:
-- My function --
     Total time      : 2102300916 ns 
     Average runtime : 13.6873 ns/op 
     Ops per second  : 73060425 op/s 
-- Other function --
     Total time      : 1455808877 ns 
     Average runtime : 9.47823 ns/op 
     Ops per second  : 105504920 op/s 
-- Average runtime ratio --
     Mine / Other's  : 1.44408 

 Performance tests with inputs in normal range with exponents close to each other:
-- My function --
     Total time      : 1191302996 ns 
     Average runtime : 11.6338 ns/op 
     Ops per second  : 85956301 op/s 
-- Other function --
     Total time      : 896641376 ns 
     Average runtime : 8.75626 ns/op 
     Ops per second  : 114203964 op/s 
-- Average runtime ratio --
     Mine / Other's  : 1.32863

fputil::generic::FMod<float16, uint16_t>::eval ("My function") vs fputil::generic::FMod<float16, uint64_t>::eval ("Other function"):

 Performance tests with inputs in denormal range:
-- My function --
     Total time      : 31902551 ns 
     Average runtime : 6.23706 ns/op 
     Ops per second  : 160332006 op/s 
-- Other function --
     Total time      : 31826412 ns 
     Average runtime : 6.22217 ns/op 
     Ops per second  : 160715571 op/s 
-- Average runtime ratio --
     Mine / Other's  : 1.00239 

 Performance tests with inputs in normal range:
-- My function --
     Total time      : 2102323737 ns 
     Average runtime : 13.6874 ns/op 
     Ops per second  : 73059632 op/s 
-- Other function --
     Total time      : 1373600760 ns 
     Average runtime : 8.943 ns/op 
     Ops per second  : 111819245 op/s 
-- Average runtime ratio --
     Mine / Other's  : 1.53052 

 Performance tests with inputs in normal range with exponents close to each other:
-- My function --
     Total time      : 1191080918 ns 
     Average runtime : 11.6316 ns/op 
     Ops per second  : 85972328 op/s 
-- Other function --
     Total time      : 895173208 ns 
     Average runtime : 8.74193 ns/op 
     Ops per second  : 114391269 op/s 
-- Average runtime ratio --
     Mine / Other's  : 1.33056

lntue · 2024-06-07T20:54:44Z

Performance test on Intel Core i7-13700H:

fputil::generic::FMod<float16, uint16_t>::eval ("My function") vs fputil::generic::FMod<float16, uint32_t>::eval ("Other function"):

 Performance tests with inputs in denormal range:
-- My function --
     Total time      : 31887746 ns 
     Average runtime : 6.23416 ns/op 
     Ops per second  : 160406445 op/s 
-- Other function --
     Total time      : 31818669 ns 
     Average runtime : 6.22066 ns/op 
     Ops per second  : 160754681 op/s 
-- Average runtime ratio --
     Mine / Other's  : 1.00217 

 Performance tests with inputs in normal range:
-- My function --
     Total time      : 2102300916 ns 
     Average runtime : 13.6873 ns/op 
     Ops per second  : 73060425 op/s 
-- Other function --
     Total time      : 1455808877 ns 
     Average runtime : 9.47823 ns/op 
     Ops per second  : 105504920 op/s 
-- Average runtime ratio --
     Mine / Other's  : 1.44408 

 Performance tests with inputs in normal range with exponents close to each other:
-- My function --
     Total time      : 1191302996 ns 
     Average runtime : 11.6338 ns/op 
     Ops per second  : 85956301 op/s 
-- Other function --
     Total time      : 896641376 ns 
     Average runtime : 8.75626 ns/op 
     Ops per second  : 114203964 op/s 
-- Average runtime ratio --
     Mine / Other's  : 1.32863

fputil::generic::FMod<float16, uint16_t>::eval ("My function") vs fputil::generic::FMod<float16, uint64_t>::eval ("Other function"):

 Performance tests with inputs in denormal range:
-- My function --
     Total time      : 31902551 ns 
     Average runtime : 6.23706 ns/op 
     Ops per second  : 160332006 op/s 
-- Other function --
     Total time      : 31826412 ns 
     Average runtime : 6.22217 ns/op 
     Ops per second  : 160715571 op/s 
-- Average runtime ratio --
     Mine / Other's  : 1.00239 

 Performance tests with inputs in normal range:
-- My function --
     Total time      : 2102323737 ns 
     Average runtime : 13.6874 ns/op 
     Ops per second  : 73059632 op/s 
-- Other function --
     Total time      : 1373600760 ns 
     Average runtime : 8.943 ns/op 
     Ops per second  : 111819245 op/s 
-- Average runtime ratio --
     Mine / Other's  : 1.53052 

 Performance tests with inputs in normal range with exponents close to each other:
-- My function --
     Total time      : 1191080918 ns 
     Average runtime : 11.6316 ns/op 
     Ops per second  : 85972328 op/s 
-- Other function --
     Total time      : 895173208 ns 
     Average runtime : 8.74193 ns/op 
     Ops per second  : 114391269 op/s 
-- Average runtime ratio --
     Mine / Other's  : 1.33056

Do you plan to add the perf tests for fmodf16 in this PR or in a separate PR?

overmighty · 2024-06-07T20:58:40Z

What would you prefer?

…of fmodf16

lntue · 2024-06-07T21:25:38Z

What would you prefer?

Having it in this PR is better.

…ions of fmodf16

overmighty · 2024-06-07T21:42:50Z

libc/test/src/math/performance_testing/BinaryOpSingleOutputPerf.h

    return 0;                                                                  \
  }
+
+#define BINARY_OP_SINGLE_OUTPUT_PERF_EX(T, myFunc, otherFunc, rounds,          \


I couldn't think of a better name for the macro.

libc/test/src/math/performance_testing/BinaryOpSingleOutputPerf.h

libc/test/src/math/performance_testing/fmodf16_perf.cpp

libc/test/src/math/performance_testing/BinaryOpSingleOutputPerf.h

github-actions · 2024-06-07T22:21:34Z

✅ With the latest revision this PR passed the C/C++ code formatter.

lntue · 2024-06-07T22:22:28Z

⚠️ C/C++ code formatter, clang-format found issues in your code. ⚠️

You can test this locally with the following command:
View the diff from clang-format here.

Please fix.

overmighty · 2024-06-07T22:23:33Z

Already fixed.

Part of llvm#93566. Signed-off-by: Hafidz Muzakky <ais.muzakky@gmail.com>

llvmbot added the libc label Jun 6, 2024

overmighty mentioned this pull request Jun 6, 2024

[gsoc2024][libc][math][c23] Implement _Float16 basic operations #93566

Closed

70 tasks

lntue self-requested a review June 6, 2024 15:21

[libc][math][c23] Add fmodf16 C23 math function

e880ee2

overmighty force-pushed the libc-math-fmodf16 branch from 7479eb4 to e880ee2 Compare June 6, 2024 15:27

[libc][math][c23] Change fmodf16 to use generic FMod with uint32_t

f6621ff

overmighty mentioned this pull request Jun 6, 2024

[libc][math][c23] Add MPFR exhaustive test for fmodf16 #94656

Merged

[libc][math][c23] Add performance test for different implementations …

002ebeb

…of fmodf16

overmighty added 2 commits June 7, 2024 23:38

[libc][math][c23] Clean up performance test for different implementat…

fff5340

…ions of fmodf16

[libc][math][c23] Remove unused dependency from performance test

21b7fe2

overmighty commented Jun 7, 2024

View reviewed changes

lntue reviewed Jun 7, 2024

View reviewed changes

libc/test/src/math/performance_testing/fmodf16_perf.cpp Outdated Show resolved Hide resolved

lntue reviewed Jun 7, 2024

View reviewed changes

libc/test/src/math/performance_testing/BinaryOpSingleOutputPerf.h Outdated Show resolved Hide resolved

[libc][math][c23] Clean up performance test again

bc2bc76

lntue approved these changes Jun 7, 2024

View reviewed changes

[libc][math][c23] Format performance test (oops)

324607f

lntue merged commit 0cdb0b7 into llvm:main Jun 7, 2024
5 of 6 checks passed

nekoshirro pushed a commit to nekoshirro/Alchemist-LLVM that referenced this pull request Jun 9, 2024

[libc][math][c23] Add fmodf16 C23 math function (llvm#94629)

6e2b58e

Part of llvm#93566. Signed-off-by: Hafidz Muzakky <ais.muzakky@gmail.com>

HerrCai0907 mentioned this pull request Jun 13, 2024

tidy #95384

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[libc][math][c23] Add fmodf16 C23 math function #94629

[libc][math][c23] Add fmodf16 C23 math function #94629

overmighty commented Jun 6, 2024

overmighty commented Jun 6, 2024

llvmbot commented Jun 6, 2024

overmighty commented Jun 6, 2024

overmighty commented Jun 6, 2024 •

edited

Loading

lntue commented Jun 7, 2024

overmighty commented Jun 7, 2024

lntue commented Jun 7, 2024

overmighty Jun 7, 2024

github-actions bot commented Jun 7, 2024 •

edited

Loading

lntue commented Jun 7, 2024

overmighty commented Jun 7, 2024

[libc][math][c23] Add fmodf16 C23 math function #94629

[libc][math][c23] Add fmodf16 C23 math function #94629

Conversation

overmighty commented Jun 6, 2024

overmighty commented Jun 6, 2024

llvmbot commented Jun 6, 2024

overmighty commented Jun 6, 2024

overmighty commented Jun 6, 2024 • edited Loading

lntue commented Jun 7, 2024

overmighty commented Jun 7, 2024

lntue commented Jun 7, 2024

overmighty Jun 7, 2024

Choose a reason for hiding this comment

github-actions bot commented Jun 7, 2024 • edited Loading

lntue commented Jun 7, 2024

overmighty commented Jun 7, 2024

overmighty commented Jun 6, 2024 •

edited

Loading

github-actions bot commented Jun 7, 2024 •

edited

Loading