-
Notifications
You must be signed in to change notification settings - Fork 12.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[LLDB][SBSaveCoreOptions] Fix TestProcessSaveCore #99692
Conversation
@llvm/pr-subscribers-lldb Author: Jacob Lalonde (Jlalond) ChangesIn #98403 some of the tests were transitioned to the new Full diff: https://github.com/llvm/llvm-project/pull/99692.diff 1 Files Affected:
diff --git a/lldb/test/API/functionalities/process_save_core/TestProcessSaveCore.py b/lldb/test/API/functionalities/process_save_core/TestProcessSaveCore.py
index 07d06bdc116ec..8573d15733927 100644
--- a/lldb/test/API/functionalities/process_save_core/TestProcessSaveCore.py
+++ b/lldb/test/API/functionalities/process_save_core/TestProcessSaveCore.py
@@ -20,8 +20,8 @@ def test_cannot_save_core_unless_process_stopped(self):
target = self.dbg.CreateTarget(exe)
process = target.LaunchSimple(None, None, self.get_process_working_directory())
self.assertNotEqual(process.GetState(), lldb.eStateStopped)
- options = SBSaveCoreOptions()
- options.SetOutputFile(SBFileSpec(core))
+ options = lldb.SBSaveCoreOptions()
+ options.SetOutputFile(lldb.SBFileSpec(core))
error = process.SaveCore(core)
self.assertTrue(error.Fail())
|
@luporl FYI this fixes the test |
@labath Would you mind looking at this? Simple fix that got missed because it's a Window's only test |
@Jlalond Thanks for the fix. |
In llvm#98403 some of the tests were transitioned to the new `SBProcess::SaveCore(SBSaveCoreOptions)` API, but were not detected in testing. This patch addresses that.
Summary: In #98403 some of the tests were transitioned to the new `SBProcess::SaveCore(SBSaveCoreOptions)` API, but were not detected in testing. This patch addresses that. Test Plan: Reviewers: Subscribers: Tasks: Tags: Differential Revision: https://phabricator.intern.facebook.com/D60251264
In #98403 some of the tests were transitioned to the new
SBProcess::SaveCore(SBSaveCoreOptions)
API, but were not detected in testing. This patch addresses that.